Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress. Update case 60 for check fix "Autoborder points are visible for invisible shapes" #3993

Conversation

dvkruchinin
Copy link
Contributor

@dvkruchinin dvkruchinin commented Dec 7, 2021

Related: #3931

Motivation and context

Adding a check for "Autoborder points are visible for invisible shapes"

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev
Copy link
Member

Hi, how exactly this PR checks that there are not points of hidden shapes in autobordering mode? I see only

cy.get('#cvat_canvas_shape_3').should('be.hidden');

but it does not guarantee us anything regarding the fixed issue.

@dvkruchinin
Copy link
Contributor Author

Hi, how exactly this PR checks that there are not points of hidden shapes in autobordering mode? I see only

cy.get('#cvat_canvas_shape_3').should('be.hidden');

but it does not guarantee us anything regarding the fixed issue.

Hi.
The main check is on line 97

testAutoborderPointsCount(8); // 8 points at the rectangles

Which checks the number of points after activating autoborder mode.
Before the fix, I got the assert that 8 != 12.

@bsekachev bsekachev merged commit f313a71 into cvat-ai:develop Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants