Add several flags to task_create CLI #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
definition.py: - Add use_zip_chunks, start_frame, stop_frame, and chunk_size as CLI flags - Rename --bug to --bug_tracker to be consistent with website and API - No longer include optional kwargs in all requests core.py: - Add a single loop to handle all kwargs for extensibility - Lump optional task_create args into kwargs for brevity
- Add back old --bug flag for backwards compatability
Update licence header for core.py
…eze/cvat into refine_task_create_cli
- Remove hardcoded `image_quality` default value, as this is already handled by the argparse default value.
- Several linting fixes for CLI
azhavoro
requested changes
Jan 12, 2022
|
Thanks for the contribution! |
- Re-add default image_quality in case task_create is called manually
|
Linting warnings have been fixed -- thanks for the heads-up. I have also re-added a hardcoded default of 70 for Please do let me know if anything else needs to be done! |
azhavoro
reviewed
Jan 13, 2022
azhavoro
previously approved these changes
Jan 13, 2022
azhavoro
approved these changes
Jan 13, 2022
nmanovic
approved these changes
Jan 13, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The current CLI is very helpful for automation, but lacks the ability to set several parameters. This pull request adds flags for setting
chunk_size,start_frame,stop_frame, anduse_zip_chunks& fixes #3855.This pull request also fixes several kinks with the
task_createCLI:bug_trackerparameter can now be passed with--bug_trackeras well as the previous flag--bug.ifstatements, making it easier to add flags in the future.**kwargsinstead of positional args.How has this been tested?
The updated create function has been called successfully from the CLI on Windows 10 (build 19043).
Checklist
developbranch[ ] I have updated the documentation accordinglycvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.