-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added intelligent function when paste labels to another task #4161
Conversation
@klakhov Could you please review the patch? Try to value the solution and find cases when it does not work |
Maybe additionally to delete on the server label/attribute IDs when create a new task/project? |
@bsekachev I've tried patch and it works as expected. No errors occur after labels copying. Also I think its better to hide deleted labels/attributes paragraph if list is empty: Btw why do we need to remove carriages if textarea does not contain them?
|
I did the proposed changes above |
Sure, I did.
It is related with textarea properties selectionStart, selectionEnd. They don't consider |
@bsekachev , I'm find with the PR. The only concern I have for now is about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you please prepare a test with the following scenario:
|
@bsekachev |
Resolved #919
Resolved #3717
Motivation and context
How has this been tested?
Manual testing
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.