Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed corner case during search #4198

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Fixed corner case during search #4198

merged 5 commits into from
Jan 20, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 19, 2022

Motivation and context

Resolved #2973

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jan 19, 2022
@bsekachev bsekachev changed the title [WIP] Fixed corner case during search Fixed corner case during search Jan 19, 2022
@bsekachev
Copy link
Member Author

@klakhov
Could you please review? Generally I removed complex code (I implemented it before for optimization), but it ends up with the fact that this optimizations brings the issue, so, I just fall the code back.

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsekachev, It seems fine if linear search does not bring heavy time loads

@bsekachev bsekachev merged commit 3c750d4 into develop Jan 20, 2022
@bsekachev bsekachev deleted the bs/fixed_issue_2973 branch January 24, 2022 07:37
@nmanovic nmanovic mentioned this pull request Mar 4, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotations search does not work correctly in some specific cases
2 participants