Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide #4812

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Update guide #4812

merged 4 commits into from
Aug 26, 2022

Conversation

azhavoro
Copy link
Contributor

Motivation and context

Add more detailed CVAT update guide than now.
Also, resolve #4598

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Sometimes the update process takes a lot of time due to changes in the database schema and data.
You can check the current status with `docker logs cvat`.
Please do not terminate the migration and wait till the process is complete.
Floow the [update guide](/docs/administration/advanced/update_guide/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azhavoro , please check gramma


## About CVAT data volumes

Docker volumes are used to store all CVAT data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azhavoro , could we show how to upgrade CVAT instance from v1.7.0 to v2.1.0? I belive in examples. It is easy to follow them. We will see (at least now), that the particular example works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably for the section it doesn't make sense. Should we add it in FAQ?

title: 'Update guide'
linkTitle: 'Update guide'
weight: 11
description: 'Instructions for updating CVAT deployed with docker compose'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call the process upgrade. Please rename 'update'/'updating' to 'upgrade'/'upgrading'.

- With git:
Run the following commands inside CVAT folder
```shell
git checkout develop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add instructions how to clone the repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we need a separate section in CVAT installation guide how to get CVAT source code. Thus here we can only provide a link.

git checkout develop
git pull
```
Optionally checkout to specific version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but Optionally checkout a specific version looks better.

- Update settings:
If `docker-compose.override.yml` configuration file is present in your installation,
check it and adjust the settings if necessary.
From time to time the installation process changes a little and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the installation process is changed/modified (drop a little)

Check the [installation guide](/docs/administration/basics/installation/) for details.

- Update settings:
If `docker-compose.override.yml` configuration file is present in your installation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I would redirect the user to the installation guide (a specific section). Here we need just basic instructions, but notify users about possible problems.

check it and adjust the settings if necessary.
From time to time the installation process changes a little and
you may need to export some environment variables, for example.
Follow the [installation guide](/docs/administration/basics/installation/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is to big. Need to point to a specific section. If it doesn't exist, I will recommend to add it.

you may need to export some environment variables, for example.
Follow the [installation guide](/docs/administration/basics/installation/).

- Update local CVAT images. Two option here:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, the process should be described somewhere in installation guide. Here we need to add a link and provide some basic instructions. For example, for v2.1.0

@nmanovic
Copy link
Contributor

@azhavoro , the primiary idea of my comments is the following:

  • We should have one installation guide tutorial with detailed instructions and multiple sections: Getting source code, Running an instance, Custom settings, etc.
  • All other guides should provide basic steps with links on specific sections in the installation guide.

It will help us to keep instructions mostly in one document. All other guides should show only basic steps. They should be simple. If users need more details, they need to read the primary installation guide.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 3562946 into develop Aug 26, 2022
@nmanovic nmanovic deleted the az/update_guide branch August 26, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backup error
2 participants