Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing notification on cloud storage creation page when manifest file is required #4921

Merged
merged 5 commits into from
Sep 12, 2022

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Sep 8, 2022

Motivation and context

Fix missing notification about required manifest file

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev
Copy link
Member

@klakhov
Can you please check the patch?

@klakhov klakhov self-assigned this Sep 9, 2022
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive to keep form consistency we need to show error message also under manifests fields.
We can use Form.ErrorList from antd. Docs and example

Something like this (under the add button seems to be better choice)
image

@nmanovic nmanovic merged commit 352501c into develop Sep 12, 2022
@nmanovic nmanovic deleted the mk/fix_missing_notification branch September 12, 2022 06:38
@nmanovic nmanovic mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants