Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: rerenders on click on project form #5156

Closed

Conversation

danil321654
Copy link

@danil321654 danil321654 commented Oct 21, 2022

Motivation and context

Project form rerenders on every click

How has this been tested?

It has been tested through React dev tools

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

https://www.loom.com/share/76484c0fde5347918d743d96127896e2

@bsekachev bsekachev self-assigned this Oct 24, 2022
@bsekachev
Copy link
Member

Hi @danil321654

Thank you for your investigations. I can submit that there are some problems with extra rerenderings. They are caused by
SortingComponent and FilteringComponent which are re-used on multiple pages. So, do you think we can do something else to fix the same issue on other pages?

@bsekachev bsekachev changed the title fix: rerenders on click on project form [WIP] fix: rerenders on click on project form Oct 26, 2022
@bsekachev
Copy link
Member

As discussed, I've proposed another fix.
If you are interested, you can find it here #5178

Anyway, thank you for finding a problem. I will close the pull request

@bsekachev bsekachev closed this Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants