Fix TUS offset queries in production environments #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SpecLad, could you add a test which resumes previous uploading? |
nmanovic
approved these changes
Oct 31, 2022
3 tasks
|
Okay, test added. |
zhiltsov-max
reviewed
Nov 7, 2022
zhiltsov-max
approved these changes
Nov 7, 2022
zhiltsov-max
reviewed
Nov 7, 2022
|
Can be merged after the imports changed. |
Previously, `mod_wsgi` would convert `HEAD` requests into `GET`, which would be rejected, so clients were unable to resume an upload that failed midway through. To make use of this, update the SDK code to enable upload resumption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
mod_wsgiwould convertHEADrequests intoGET, which would be rejected, so clients were unable to resume an upload that failed midway through.To make use of this, update the SDK code to enable upload resumption.
Motivation and context
Fixes #4839.
How has this been tested?
SDK unit tests. For the old server workaround, I manually disabled the fix and checked that the tests still pass.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.