cvat-sdk: remove broken and unused body-to-params conversion #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's broken, because it generates a multipart/form-data body that Django REST Framework cannot parse. DRF doesn't examine the individual Content-Type headers of parts, so it interprets the JSON-encoded values as `str()`-encoded values, which corrupts them. Since this logic is also currently unused (and it's unclear whether it will ever be used again), remove it.
SpecLad
force-pushed
the
dont-convert-body-to-params
branch
from
821d77a
to
541a88e
Compare
nmanovic
approved these changes
Nov 7, 2022
|
/check |
|
❌ Some checks failed |
|
@SpecLad , what is the next step with the PR? |
It's on the backburner for now, because some tests don't pass and I can't fix them easily. It's not blocking anything, so I'll come bsck to it if this issue becomes relevant again (or if I have a spare minute). |
|
I decided to fix this in a different way. I'll open a new PR, since it won't have much in common with this. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's broken, because it generates a multipart/form-data body that Django REST Framework cannot parse. DRF doesn't examine the individual Content-Type headers of parts, so it interprets the JSON-encoded values as
str()-encoded values, which corrupts them.Since this logic is also currently unused (and it's unclear whether it will ever be used again), remove it.
Motivation and context
This is a follow-up to #5058.
How has this been tested?
Relying on CI for this.
Checklist
developbranch[ ] I have added a description of my changes into CHANGELOG file[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.