Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attaching manifest file with custom name #5377

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Conversation

Marishka17
Copy link
Contributor

Motivation and context

Closes #5361

How has this been tested?

Updated existing cypress test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 changed the title Mk/fix issue 5361 Fix attaching manifest file with custom name Nov 30, 2022
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marishka17 , from my perspective it looks great!

@bsekachev , could you please look and approve?

@Marishka17 Marishka17 changed the title Fix attaching manifest file with custom name [WIP] Fix attaching manifest file with custom name Nov 30, 2022
@Marishka17
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2022

✔️ All checks completed successfully
📄 See logs here

@Marishka17 Marishka17 changed the title [WIP] Fix attaching manifest file with custom name Fix attaching manifest file with custom name Nov 30, 2022
@nmanovic nmanovic merged commit ca83d3c into develop Nov 30, 2022
@nmanovic nmanovic deleted the mk/fix_issue_5361 branch November 30, 2022 14:25
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to attach manifest file with dataset when creating a task
3 participants