-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix attaching manifest file with custom name #5377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marishka17
changed the title
Mk/fix issue 5361
Fix attaching manifest file with custom name
Nov 30, 2022
nmanovic
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marishka17 , from my perspective it looks great!
@bsekachev , could you please look and approve?
Marishka17
changed the title
Fix attaching manifest file with custom name
[WIP] Fix attaching manifest file with custom name
Nov 30, 2022
…to mk/fix_issue_5361
/check |
✔️ All checks completed successfully |
Marishka17
changed the title
[WIP] Fix attaching manifest file with custom name
Fix attaching manifest file with custom name
Nov 30, 2022
bsekachev
approved these changes
Nov 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Closes #5361
How has this been tested?
Updated existing cypress test
Checklist
develop
branch- [ ] I have updated the documentation accordinglycvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.