Fix exception when run export for an empty task #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR contains simple fix. Just return BAD REQUEST if somebody tries to export a task without data. It doesn't make sense. But more complex fix will require to change to huge amount of code. In any case it doesn't make any sense to support such weird scenario.
Marishka17
approved these changes
Nov 30, 2022
Merged
nmanovic
added a commit
that referenced
this pull request
Dec 2, 2022
Merged
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
Fixed REST API tests after merging cvat-ai#5408 and cvat-ai#5396 to develop Co-authored-by: Boris Sekachev <sekachev.bs@gmail.com> Co-authored-by: Nikita Manovich <nikita@cvat.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5245
The PR contains a simple fix. Just return BAD REQUEST if somebody tries to export a task without data. It doesn't make sense. But a more complex fix will require changing a massive amount of code. It doesn't make any sense to support such a weird scenario.