Migrate to Docker Compose V2 #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the "latest and recommended version" of the format: <https://docs.docker.com/compose/compose-file/>.
|
I added the file format change to the changelog. The rest I don't think is changelog-worthy, because it's just documentation and CI scripts. It's still possible to use Compose V1 with our Compose files, so it's not a breaking change. |
|
@azhavoro , could you please look? |
|
LGTM |
azhavoro
approved these changes
Dec 29, 2022
2 tasks
4 tasks
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
Also, migrate to the version less Compose file format. Compose V1 is EOL: <https://www.docker.com/blog/announcing-compose-v2-general-availability/>.
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
…t-ai#5545) I was supposed to do this in cvat-ai#5524 when I was removing them everywhere else, but I didn't think to search the documentation. Compose override files must have the same format as the base file, otherwise Docker Compose rejects them. Fixes cvat-ai#5544.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, migrate to the versionless Compose file format.
Motivation and context
Compose V1 is EOL: https://www.docker.com/blog/announcing-compose-v2-general-availability/.
How has this been tested?
--stop-services,--rebuildand with no options to make sure that building, running and stopping the services still works.docker compose -f <...> configfor all Compose files to make sure that the syntax is still considered valid by Compose V2.Note that I did not test the Windows or macOS Installation Guide, but Docker Desktop now comes with Compose V2, so no special install steps should be needed.
Checklist
developbranch[ ] I have added tests to cover my changes[ ] I have linked related issues (read github docs)[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.