Remove collections in endpoints #5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zm/improve-some-endpoints
…s-in-endpoints' into zm/remove-duplicating-collections-in-endpoints
…ing-collections-in-endpoints
zhiltsov-max
force-pushed
the
zm/remove-duplicating-collections-in-endpoints
branch
from
0136262
to
9f36ebb
Compare
…s-in-endpoints' into zm/remove-duplicating-collections-in-endpoints
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| db_label.save() | ||
| except models.InvalidLabel as exc: | ||
| raise exceptions.ValidationError(str(exc)) from exc |
Check warning
Code scanning / CodeQL
Information exposure through an exception
zhiltsov-max
changed the title
zhiltsov-max
changed the title
Marishka17
approved these changes
Feb 21, 2023
| fields = ('id', 'name', 'color', 'attributes', 'deleted', 'type', 'svg', 'sublabels', 'has_parent') | ||
| fields = ( | ||
| 'id', 'name', 'color', 'attributes', 'deleted', 'type', 'svg', | ||
| 'sublabels', 'project_id', 'task_id', 'parent_id', 'has_parent' |
There was a problem hiding this comment.
As we discussed need to keep only one field has_parent or parent_id in the next PR (probably parent_id is more informative)
Co-authored-by: Maria Khrustaleva <maya17grd@gmail.com>
2 tasks
…s://github.com/opencv/cvat into zm/remove-duplicating-collections-in-endpoints
nmanovic
pushed a commit
that referenced
this pull request
Feb 21, 2023
Updates changelog after #5662
This was referenced Feb 28, 2023
6 tasks
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
This PR is focused on server performance optimization for requests with
collections.
- Collections with user-controlled size are removed from server output
and replaced
with structures providing links to the matching paginated endpoints and
summary info:
- /api/projects/{id}.tasks -> /api/tasks?project_id={id}
- /api/tasks/{id}.segments -> /api/jobs?task_id={id}: .start_frame,
.stop_frame
- /api/jobs/{id}.issues -> /api/issues?job_id={id}
- /api/issues/{id}.comments -> /api/comments?issue_id={id}
- /api/projects | tasks | jobs/{id}.labels -> /api/labels?
project_id|task_id|job_id={id}
- Added Label-related endpoints:
- /api/labels (GET)
- /api/labels/{id} (GET, PATCH, DELETE)
- PATCH and DELETE both cannot be used for sublabels
- Added and updated tests
- Removed unused test server data
- Added several new cases with skeletons and ownerships
- Fixed possible problems with duplicate labels appearing on renaming
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
Updates changelog after cvat-ai#5662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR is focused on server performance optimization for requests with collections.
with structures providing links to the matching paginated endpoints and summary info:
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.