Fix Nuclio function invocations when deployed via the Helm chart #5917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
force-pushed
the
helm-nuclio-env
branch
from
945f358
to
4f80e8a
Compare
|
@SpecLad |
The `CVAT_NUCLIO_FUNCTION_NAMESPACE` variable needs to be defined consistently in order for Nuclio integration to work. Currently, it's set to `cvat` for the main CVAT server process, but not for any other CVAT process (which means it defaults to `nuclio` in those processes). Since it's the annotation worker process that actually invokes the Nuclio functions, the invocation fails. Fix it by synchronizing the Nuclio environment variables across all backend deployments. Technically, I think only the server and annotation worker deployments need these variables, but since they're accessed by `cvat/settings/base.py` in every process that loads Django, define them everywhere to be sure.
SpecLad
force-pushed
the
helm-nuclio-env
branch
from
353c827
to
2e03b8e
Compare
|
Sure; updated. |
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
…t-ai#5917) The `CVAT_NUCLIO_FUNCTION_NAMESPACE` needs to be defined consistently in order for Nuclio integration to work. Currently, it's set to `cvat` for the main CVAT server process, but not for any other CVAT process (which means it defaults to `nuclio` in those processes). Since it's the annotation worker process that actually invokes the Nuclio functions, the invocation fails. Fix it by synchronizing the Nuclio environment variables across all backend deployments. Technically, I think only the server and annotation worker deployments need these variables, but since they're accessed by `cvat/settings/base.py` in every process that loads Django, define them everywhere to be sure. Fixes cvat-ai#5626.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CVAT_NUCLIO_FUNCTION_NAMESPACEneeds to be defined consistently in order for Nuclio integration to work. Currently, it's set tocvatfor the main CVAT server process, but not for any other CVAT process (which means it defaults tonuclioin those processes). Since it's the annotation worker process that actually invokes the Nuclio functions, the invocation fails.Fix it by synchronizing the Nuclio environment variables across all backend deployments. Technically, I think only the server and annotation worker deployments need these variables, but since they're accessed by
cvat/settings/base.pyin every process that loads Django, define them everywhere to be sure.Motivation and context
Fixes #5626.
How has this been tested?
Manual testing on a local minikube cluster. Also, by running
helm upgrade --dry-run.Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.