Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: fix urllib3 deprecation warnings #6002

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Apr 10, 2023

Motivation and context

HTTPResponse.getheader and getheaders are slated to be removed in urllib3 2.1.0.

How has this been tested?

Unit tests.

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

I will need to customize it to fix a deprecation warning.
`HTTPResponse.getheader` and `getheaders` are slated to be removed in
urllib3 2.1.0.
@SpecLad SpecLad marked this pull request as ready for review April 10, 2023 16:30
@SpecLad SpecLad requested a review from mdacoca as a code owner April 10, 2023 16:30
@nmanovic nmanovic merged commit 2505b31 into cvat-ai:develop Apr 10, 2023
@SpecLad SpecLad deleted the fix-urllib3-deprecation branch April 10, 2023 18:28
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
`HTTPResponse.getheader` and `getheaders` are slated to be removed in
urllib3 2.1.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants