Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis and Redis accessories #6016

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Apr 12, 2023

Motivation and context

This originally started as a security update for redis-py (see https://github.com/redis/redis-py/releases/tag/v4.5.3, https://github.com/redis/redis-py/releases/tag/v4.5.4). However, I also had to update other Redis-related components because of incompatibilities.

  • The old version of fakeredis is not compatible with the redis-py 4.x, so I bumped it too. This also allowed me to remove the six workaround.

  • redis-py 4.1.0 and newer don't support Redis < 5, so I bumped Redis itself in docker-compose.yml. Note that the Helm chart is already using Redis 7.0.x.

Obsoletes #5946.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

This originally started as a security update for redis-py (see
<https://github.com/redis/redis-py/releases/tag/v4.5.3>,
<https://github.com/redis/redis-py/releases/tag/v4.5.4>). However, I also
had to update other Redis-related components because of incompatibilities.

* The old version of fakeredis is not compatible with the redis-py 4.x,
  so I bumped it too. This also allowed me to remove the six workaround.

* redis-py 4.1.0 and newer don't support Redis < 5, so I bumped Redis
  itself in `docker-compose.yml`. Note that the Helm chart is already using
  Redis 7.0.x.
@SpecLad SpecLad marked this pull request as ready for review April 12, 2023 15:13
@nmanovic nmanovic merged commit b8cdd4e into cvat-ai:develop Apr 18, 2023
@SpecLad SpecLad deleted the bump-redis-py branch April 18, 2023 18:36
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
This originally started as a security update for redis-py (see
<https://github.com/redis/redis-py/releases/tag/v4.5.3>,
<https://github.com/redis/redis-py/releases/tag/v4.5.4>). However, I
also had to update other Redis-related components because of
incompatibilities.

* The old version of fakeredis is not compatible with the redis-py 4.x,
so I bumped it too. This also allowed me to remove the six workaround.

* redis-py 4.1.0 and newer don't support Redis < 5, so I bumped Redis
itself in `docker-compose.yml`. Note that the Helm chart is already
using Redis 7.0.x.

Obsoletes cvat-ai#5946.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants