Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rerun the tests when the PR description is edited #6373

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Jun 26, 2023

Motivation and context

Most of the time it's useless and just clogs up the build queue. When it's useful (e.g. when removing "[Dependent]" from the title), it's easy enough to retrigger the build manually by updating your branch.

Fixes #5921.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Most of the time it's useless and just clogs up the build queue. When it's
useful (e.g. when removing "[Dependent]" from the title), it's easy enough to
retrigger the build manually by updating your branch.
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #6373 (baf26d3) into develop (8590e90) will increase coverage by 7.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6373      +/-   ##
===========================================
+ Coverage    72.90%   80.11%   +7.20%     
===========================================
  Files          300      331      +31     
  Lines        36882    38431    +1549     
  Branches      3594     6923    +3329     
===========================================
+ Hits         26890    30789    +3899     
+ Misses        9986     7332    -2654     
- Partials         6      310     +304     
Components Coverage Δ
cvat-ui 74.67% <ø> (-0.03%) ⬇️
cvat-server 85.16% <ø> (+14.05%) ⬆️

Copy link
Contributor

@sizov-kirill sizov-kirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest notifying our core team about these changes because I think some people got used to using the "[WIP]" prefix for their PRs.

@SpecLad
Copy link
Contributor Author

SpecLad commented Jun 26, 2023

Yeah, that's a good point.

@bsekachev bsekachev merged commit 7ec84b8 into cvat-ai:develop Jun 27, 2023
@SpecLad SpecLad deleted the no-ci-on-edit branch June 28, 2023 10:15
@sizov-kirill sizov-kirill mentioned this pull request Jul 17, 2023
7 tasks
SpecLad pushed a commit that referenced this pull request Jul 18, 2023
Duplicate #6373 for Helm tests
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When change PR name/description it causes CI to re-run
3 participants