Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Python linter workflows #6577

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Jul 28, 2023

Motivation and context

Use pipx (preinstalled on GitHub-hosted runners), which takes care of
virtual environments for us. Remove the apt-get commands; we don't actually
need the packages that they're installing.

How has this been tested?

I added a test commit to this PR to make sure the linters still run correctly.

Checklist

  • I submit my changes into the develop branch
  • [ ] I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Use pipx (preinstalled on GitHub-hosted runners), which takes care of
virtual environments for us. Remove the apt-get commands; we don't actually
need the packages that they're installing.
@SpecLad SpecLad force-pushed the rm-pointless-packages branch 2 times, most recently from 5466369 to 0d6d35c Compare July 28, 2023 12:07
@SpecLad SpecLad marked this pull request as ready for review July 28, 2023 16:28
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #6577 (0d6d35c) into develop (4b86439) will increase coverage by 0.03%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6577      +/-   ##
===========================================
+ Coverage    81.12%   81.16%   +0.03%     
===========================================
  Files          363      363              
  Lines        39644    39599      -45     
  Branches      3563     3557       -6     
===========================================
- Hits         32160    32139      -21     
+ Misses        7484     7460      -24     
Components Coverage Δ
cvat-ui 74.87% <ø> (+0.06%) ⬆️
cvat-server 86.72% <ø> (+<0.01%) ⬆️

@SpecLad SpecLad merged commit 4c1ff85 into cvat-ai:develop Jul 31, 2023
43 checks passed
@SpecLad SpecLad deleted the rm-pointless-packages branch July 31, 2023 10:46
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Use pipx (preinstalled on GitHub-hosted runners), which takes care of
virtual environments for us. Remove the apt-get commands; we don't
actually need the packages that they're installing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants