Remove the YOLOv5 dependency from the YOLOv7 serverless function #6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the YOLOv7 function uses `ultralytics/yolov5` as the base image, despite not depending on YOLOv5 in any way. Replace it with generic base images.
|
I have tested this PR on GPU, it works fine. |
|
@kirill-sizov Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #6619 +/- ##
===========================================
- Coverage 81.25% 81.25% -0.01%
===========================================
Files 368 368
Lines 39813 39813
Branches 3557 3557
===========================================
- Hits 32352 32351 -1
- Misses 7461 7462 +1
|
sizov-kirill
approved these changes
Aug 7, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
…t-ai#6619) For some reason, the YOLOv7 function uses `ultralytics/yolov5` as the base image, despite not depending on YOLOv5 in any way. Replace it with generic base images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
For some reason, the YOLOv7 function uses
ultralytics/yolov5as the base image, despite not depending on YOLOv5 in any way. Replace it with generic base images.How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have added a description of my changes into the CHANGELOG file[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.