Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release notes update #6656

Merged
merged 9 commits into from
Aug 11, 2023
Merged

release notes update #6656

merged 9 commits into from
Aug 11, 2023

Conversation

mdacoca
Copy link
Contributor

@mdacoca mdacoca commented Aug 11, 2023

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@mdacoca mdacoca requested a review from SpecLad August 11, 2023 10:47
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
(<https://github.com/opencv/cvat/pull/6575>)
- \[SDK\] Custom `ProgressReporter` implementations should now override `start2` instead of `start`
- \[SDK\] Custom `ProgressReporter` implementations must now override `start2` instead of start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really a must. Old implementations that overrode start will still work. It's just a recommentation for future implementations.

And why did you remove code formatting for start?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping?

@mdacoca mdacoca marked this pull request as ready for review August 11, 2023 12:40
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
mdacoca and others added 2 commits August 11, 2023 15:15
Co-authored-by: Roman Donchenko <roman@cvat.ai>
CHANGELOG.md Outdated Show resolved Hide resolved
@SpecLad SpecLad merged commit d61a7b1 into develop Aug 11, 2023
11 checks passed
@SpecLad SpecLad deleted the ma/rn-review branch August 11, 2023 13:47
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants