Different fixes for Release 0.5.0 #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
reviewed
Aug 27, 2019
| self.db_jobs = models.Job.objects.select_related("segment").filter(segment__task_id=pk) | ||
|
|
||
| # Postgres doesn't guarantee an order by default without explicit order_by | ||
| self.db_jobs = models.Job.objects.select_related("segment").filter(segment__task_id=pk).order_by('id') |
There was a problem hiding this comment.
@bsekachev , Was the line a reason for problems with an assert for tasks with several jobs?
There was a problem hiding this comment.
@nmanovic
Yes, it was. TaskAnnotation was formed wrong due to a segments order.
nmanovic
approved these changes
Aug 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #666
Resolved #610
Resolved #500
Also fixed: