Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled TUS resume upload option (not used, but pollutes local storage) #6976

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

bsekachev
Copy link
Member

Motivation and context

Do not pollute local storage by TUS records.
Details are here: https://github.com/tus/tus-js-client/blob/main/docs/api.md#storefingerprintforresuming

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #6976 (7a3bb9f) into develop (e699848) will decrease coverage by 0.01%.
Report is 11 commits behind head on develop.
The diff coverage is 90.90%.

@@             Coverage Diff             @@
##           develop    #6976      +/-   ##
===========================================
- Coverage    82.58%   82.57%   -0.01%     
===========================================
  Files          360      360              
  Lines        38914    38925      +11     
  Branches      3570     3570              
===========================================
+ Hits         32137    32144       +7     
- Misses        6777     6781       +4     
Components Coverage Δ
cvat-ui 77.60% <90.90%> (+<0.01%) ⬆️
cvat-server 87.13% <ø> (-0.01%) ⬇️

@bsekachev bsekachev merged commit 176bac2 into develop Oct 11, 2023
33 checks passed
@bsekachev bsekachev deleted the bs/fixed_local_storage_garbage_after_tus branch October 12, 2023 05:57
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants