Override EditorConfig settings for YAML files #6980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized that I was fighting my editor, because we indent YAML files with 2 spaces, but `.editorconfig` specifies 4 spaces for all files. Align the config with reality.
Codecov Report
@@ Coverage Diff @@
## develop #6980 +/- ##
===========================================
- Coverage 82.58% 82.57% -0.02%
===========================================
Files 360 360
Lines 38914 38925 +11
Branches 3570 3570
===========================================
+ Hits 32137 32142 +5
- Misses 6777 6783 +6
|
nmanovic
approved these changes
Oct 11, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
I realized that I was fighting my editor, because we indent YAML files with 2 spaces, but `.editorconfig` specifies 4 spaces for all files. Align the config with reality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
I realized that I was fighting my editor, because we indent YAML files with 2 spaces, but
.editorconfigspecifies 4 spaces for all files.Align the config with reality.
How has this been tested?
I checked that the settings were applied correctly with the CLI
editorconfigtool.Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.