Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackerMIL optimizations #7032

Merged
merged 8 commits into from
Oct 24, 2023
Merged

TrackerMIL optimizations #7032

merged 8 commits into from
Oct 24, 2023

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Oct 19, 2023

Motivation and context

This PR fixes some problems with TrackerMIL memory managment

  • Free up some memory after we are done with tracking
  • Stable memory consuption while tracking (no endlessly raising heap size)
    Open a task with quite large images 2k -> create a couple of tracks -> track a couple of frames:
    tracking

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov marked this pull request as ready for review October 19, 2023 11:08
@klakhov klakhov changed the title [WIP] TrackerMIL optimizations TrackerMIL optimizations Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #7032 (1c0b883) into develop (8197cd2) will increase coverage by 0.01%.
Report is 19 commits behind head on develop.
The diff coverage is 42.85%.

@@             Coverage Diff             @@
##           develop    #7032      +/-   ##
===========================================
+ Coverage    82.33%   82.34%   +0.01%     
===========================================
  Files          361      361              
  Lines        39171    39181      +10     
  Branches      3586     3584       -2     
===========================================
+ Hits         32251    32265      +14     
+ Misses        6920     6916       -4     
Components Coverage Δ
cvat-ui 77.31% <33.33%> (-0.01%) ⬇️
cvat-server 86.97% <100.00%> (+0.02%) ⬆️

@klakhov klakhov merged commit c6682ff into develop Oct 24, 2023
33 checks passed
@klakhov klakhov deleted the kl/tracker-mil-optimizations branch October 25, 2023 07:24
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
This PR fixes some problems with TrackerMIL memory managment
- Free up some memory after we are done with tracking
- Stable memory consuption while tracking (no endlessly raising heap
size)
Open a task with quite large images 2k -> create a couple of tracks ->
track a couple of frames:

![tracking](https://github.com/opencv/cvat/assets/50956430/087910dd-a0c8-4007-a25c-6952743c2f36)



### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
@cvat-bot cvat-bot bot mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants