-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
504 on save annotation, workaround #7286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
changed the title
[WIP] 504 on save annotation, workaround
504 on save annotation, workaround
Dec 25, 2023
bsekachev
commented
Dec 25, 2023
@@ -91,31 +91,6 @@ export class Exception extends Error { | |||
}), | |||
); | |||
} | |||
|
|||
async save(): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used api, we use events
api to save exceptions
serverProxy.server.exception
even is not implemented
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7286 +/- ##
===========================================
- Coverage 83.09% 82.94% -0.16%
===========================================
Files 372 372
Lines 39500 39576 +76
Branches 3665 3688 +23
===========================================
+ Hits 32824 32826 +2
- Misses 6676 6750 +74
|
klakhov
reviewed
Dec 26, 2023
klakhov
approved these changes
Dec 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolved #7292
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.