Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

504 on save annotation, workaround #7286

Merged
merged 19 commits into from
Dec 27, 2023
Merged

504 on save annotation, workaround #7286

merged 19 commits into from
Dec 27, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Dec 21, 2023

Motivation and context

image

Resolved #7292

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev changed the title [WIP] 504 on save annotation, workaround 504 on save annotation, workaround Dec 25, 2023
@bsekachev bsekachev marked this pull request as ready for review December 25, 2023 09:43
@@ -91,31 +91,6 @@ export class Exception extends Error {
}),
);
}

async save(): Promise<void> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used api, we use events api to save exceptions
serverProxy.server.exception even is not implemented

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Merging #7286 (3f04450) into develop (06c6a76) will decrease coverage by 0.16%.
The diff coverage is 63.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7286      +/-   ##
===========================================
- Coverage    83.09%   82.94%   -0.16%     
===========================================
  Files          372      372              
  Lines        39500    39576      +76     
  Branches      3665     3688      +23     
===========================================
+ Hits         32824    32826       +2     
- Misses        6676     6750      +74     
Components Coverage Δ
cvat-ui 78.40% <62.85%> (-0.31%) ⬇️
cvat-server 87.09% <100.00%> (-0.01%) ⬇️

cvat-core/src/annotations-objects.ts Show resolved Hide resolved
cvat-core/src/annotations-objects.ts Show resolved Hide resolved
cvat-core/src/annotations-objects.ts Show resolved Hide resolved
cvat/apps/dataset_manager/task.py Show resolved Hide resolved
@bsekachev bsekachev merged commit fb610a4 into develop Dec 27, 2023
34 checks passed
@bsekachev bsekachev deleted the bs/retry_if_504 branch December 27, 2023 08:48
@cvat-bot cvat-bot bot mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not consistent rest api when returning annotations
2 participants