-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC2024] Decode uploaded filename from request header #7646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Please consider to add a API test to check this case.
@@ -0,0 +1,4 @@ | |||
### Fixed | |||
|
|||
- Creating tasks with special characters in uploaded filename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that other upload-related functions work with such characters in file names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bulk (non-TUS) uploads work fine. I'm not sure how to do remote and cloud uploads. Can I test those through the testing framework?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7646 +/- ##
===========================================
- Coverage 83.36% 83.34% -0.02%
===========================================
Files 373 373
Lines 39722 39722
Branches 3747 3747
===========================================
- Hits 33113 33106 -7
- Misses 6609 6616 +7
|
@azhavoro I'm not sure how to add the API test case, since this problem only happens through TUS uploads. How do I make sure a file is uploaded through TUS using the testing framework? Does the test case need to be in cypress instead of pytest? |
Yes, it looks like the cypres test is the easiest way to initiate uploading via TUS. |
Thanks for the contribution! |
Motivation and context
This fixes issue #6528, as filenames with special characters must be decoded from the MIME header back into UTF-8.
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.