[GSoC2024] - fix/attribute-text-length-limited-for-adding-values

[ritikraj26]

Doubled the maximum length of the attribute values.

Motivation and context

It provides a solution to the issue here

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
  - [ ] I have updated the documentation accordingly
  - [ ] I have added tests to cover my changes
• I have linked related issues (see GitHub docs)
  - [ ] I have increased versions of npm packages if it is necessary
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

• New Features
  • Doubled the maximum length of attribute values, allowing for more detailed entries in the system.

[bsekachev]

@Marishka17

Do you have any comments to the pull request?

[nmanovic]

@coderabbitai review

[coderabbitai]

Walkthrough

The recent system update has doubled the maximum length of attribute values, enabling more extensive data storage and annotations system-wide.

Changes

File Path	Change Summary
changelog.d/20240413_..._attribute_text_length_limited_for_adding_values.md cvat/apps/engine/migrations/.../0079_alter_attributespec_values.py cvat/apps/engine/models.py	Updated to double the maximum length of attribute values in the system.

Poem

🐇💻

In the realm of data, a change takes flight,

Attribute values now have more space, oh what a sight!

From 4096 to 8192, the data can thrive,

A rabbit's magic touch, helping data come alive!

Let's dance in binary, let's sing in code,

For expanded horizons where data can now abode! 🎉📊

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 73b5ead and 3011102.

Files selected for processing (1)

• changelog.d/20240413_031652_ritikraj2699_attribute_text_length_limited_for_adding_values.md (1 hunks)

Additional Context Used

LanguageTool (1)

changelog.d/20240413_031652_ritikraj2699_attribute_text_length_limited_for_adding_values.md (1)

Near line 3: Possible typo: you repeated a whitespace
Context: ...maximum length of the attribute values. (<#7...

Additional comments not posted (1)

changelog.d/20240413_031652_ritikraj2699_attribute_text_length_limited_for_adding_values.md (1)

3-4: Changelog update looks good and clearly communicates the changes made.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[bsekachev]

@Marishka17

Can you please review it?

[Marishka17]

Probably, it is not a good solution to increase the limit here and use CharField. Since we're using PostgreSQL, there shouldn't be any problems with wasting memory when the values field is small, but... Perhaps it will be better to use TextField here and add a limit in the code (but not to the values field since we store a list with attribute values in a string with a custom separator) - introduce an upper limit on the max number of characters for an attribute value and max number of attributes. + This looks logical to me also because we have a limit for AttributeVal.value.