Remove unnecessary fields from the /api/lambda/functions response
#8004
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent updates primarily focus on removing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (28)
- cvat-core/src/ml-model.ts (1 hunks)
- cvat/apps/lambda_manager/views.py (3 hunks)
- serverless/onnx/WongKinYiu/yolov7/nuclio/function-gpu.yaml (1 hunks)
- serverless/onnx/WongKinYiu/yolov7/nuclio/function.yaml (1 hunks)
- serverless/openvino/dextr/nuclio/function.yaml (1 hunks)
- serverless/openvino/omz/intel/face-detection-0205/nuclio/function.yaml (1 hunks)
- serverless/openvino/omz/intel/person-reidentification-retail-0277/nuclio/function.yaml (1 hunks)
- serverless/openvino/omz/intel/semantic-segmentation-adas-0001/nuclio/function.yaml (1 hunks)
- serverless/openvino/omz/intel/text-detection-0004/nuclio/function.yaml (1 hunks)
- serverless/openvino/omz/public/faster_rcnn_inception_resnet_v2_atrous_coco/nuclio/function.yaml (1 hunks)
- serverless/openvino/omz/public/mask_rcnn_inception_resnet_v2_atrous_coco/nuclio/function.yaml (1 hunks)
- serverless/openvino/omz/public/yolo-v3-tf/nuclio/function.yaml (1 hunks)
- serverless/pytorch/dschoerk/transt/nuclio/function-gpu.yaml (1 hunks)
- serverless/pytorch/dschoerk/transt/nuclio/function.yaml (1 hunks)
- serverless/pytorch/facebookresearch/detectron2/retinanet_r101/nuclio/function-gpu.yaml (1 hunks)
- serverless/pytorch/facebookresearch/detectron2/retinanet_r101/nuclio/function.yaml (1 hunks)
- serverless/pytorch/facebookresearch/sam/nuclio/function-gpu.yaml (1 hunks)
- serverless/pytorch/facebookresearch/sam/nuclio/function.yaml (1 hunks)
- serverless/pytorch/foolwood/siammask/nuclio/function-gpu.yaml (1 hunks)
- serverless/pytorch/foolwood/siammask/nuclio/function.yaml (1 hunks)
- serverless/pytorch/mmpose/hrnet32/nuclio/function.yaml (1 hunks)
- serverless/pytorch/saic-vul/fbrs/nuclio/function.yaml (1 hunks)
- serverless/pytorch/saic-vul/hrnet/nuclio/function-gpu.yaml (1 hunks)
- serverless/pytorch/saic-vul/hrnet/nuclio/function.yaml (1 hunks)
- serverless/pytorch/shiyinzhang/iog/nuclio/function.yaml (1 hunks)
- serverless/tensorflow/faster_rcnn_inception_v2_coco/nuclio/function-gpu.yaml (1 hunks)
- serverless/tensorflow/faster_rcnn_inception_v2_coco/nuclio/function.yaml (1 hunks)
- site/content/en/docs/manual/advanced/serverless-tutorial.md (1 hunks)
Files skipped from review due to trivial changes (24)
- serverless/onnx/WongKinYiu/yolov7/nuclio/function-gpu.yaml
- serverless/onnx/WongKinYiu/yolov7/nuclio/function.yaml
- serverless/openvino/dextr/nuclio/function.yaml
- serverless/openvino/omz/intel/face-detection-0205/nuclio/function.yaml
- serverless/openvino/omz/intel/person-reidentification-retail-0277/nuclio/function.yaml
- serverless/openvino/omz/intel/semantic-segmentation-adas-0001/nuclio/function.yaml
- serverless/openvino/omz/intel/text-detection-0004/nuclio/function.yaml
- serverless/openvino/omz/public/faster_rcnn_inception_resnet_v2_atrous_coco/nuclio/function.yaml
- serverless/openvino/omz/public/mask_rcnn_inception_resnet_v2_atrous_coco/nuclio/function.yaml
- serverless/openvino/omz/public/yolo-v3-tf/nuclio/function.yaml
- serverless/pytorch/dschoerk/transt/nuclio/function-gpu.yaml
- serverless/pytorch/dschoerk/transt/nuclio/function.yaml
- serverless/pytorch/facebookresearch/detectron2/retinanet_r101/nuclio/function-gpu.yaml
- serverless/pytorch/facebookresearch/detectron2/retinanet_r101/nuclio/function.yaml
- serverless/pytorch/facebookresearch/sam/nuclio/function-gpu.yaml
- serverless/pytorch/facebookresearch/sam/nuclio/function.yaml
- serverless/pytorch/foolwood/siammask/nuclio/function-gpu.yaml
- serverless/pytorch/foolwood/siammask/nuclio/function.yaml
- serverless/pytorch/mmpose/hrnet32/nuclio/function.yaml
- serverless/pytorch/saic-vul/fbrs/nuclio/function.yaml
- serverless/pytorch/saic-vul/hrnet/nuclio/function-gpu.yaml
- serverless/pytorch/saic-vul/hrnet/nuclio/function.yaml
- serverless/tensorflow/faster_rcnn_inception_v2_coco/nuclio/function-gpu.yaml
- serverless/tensorflow/faster_rcnn_inception_v2_coco/nuclio/function.yaml
Additional context used
LanguageTool
In this case the container was built some time ago a...site/content/en/docs/manual/advanced/serverless-tutorial.md
[style] ~9-~9: Consider using a different verb to strengthen your wording. (FIX_CORRECT)
Context: ...puters to solve daily routine problems, fix mistakes, and find information has beco...
[uncategorized] ~25-~25: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...ate faster, how then do we use them? In CVAT all such DL models are implemented as s...
[uncategorized] ~33-~33: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE_2)
Context: ...ate data. What is a serverless function and why is it used for automatic annotation...
[typographical] ~37-~37: Consider adding a comma here. (FOR_THAT_COMMA)
Context: ...at] or [Pascal VOC][pascal-voc-format]. After that you can upload the annotation file into...
[uncategorized] ~38-~38: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... the annotation file into CVAT. It works but it is not user-friendly. How to make CV...
[uncategorized] ~48-~48: A comma may be missing after the conjunctive/linking adverb ‘Thus’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...uto-annotation-guide] for instructions. Thus if you deploy a serverless function, th...
[uncategorized] ~50-~50: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... call it with appropriate arguments. Of course there are some tricks how to create ser...
[uncategorized] ~51-~51: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ... to create serverless functions for CVAT and we will discuss them in next sections o...
[uncategorized] ~58-~58: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...-github]. To build CVAT with serverless support you need to rundocker composecomman...
[style] ~85-~85: Consider an alternative to avoid wordiness and to strengthen your wording. (IN_THE_BEGINNING_INITIALLY)
Context: ...llowing command to check that it works. In the beginning you should not have any deployed server...
[typographical] ~100-~100: It appears that a comma is missing. (DURING_THAT_TIME_COMMA)
Context: ...## Tracking using SiamMask In this use case a user needs to annotate all individual...
[formatting] ~101-~101: Consider adding a comma after ‘Basically’ for more clarity. (CONJUNCTIVE_LINKING_ADVERB_COMMA_PREMIUM)
Context: ...ndividual objects on a video as tracks. Basically for every object we need to know its lo...
[typographical] ~104-~104: It is considered good style to insert a comma after introductory phrases with dates or proper nouns. (IN_NNP_COMMA)
Context: ...can depend on your operating system. On Linux you can useserverless/deploy_cpu.sh...
[typographical] ~158-~158: Consider adding a comma after ‘Finally’ for more clarity. (RB_LY_COMMA)
Context: ...g an object](/images/trackers_tab.jpg) Finally you will get bounding boxes. ![SiamMas...
[style] ~167-~167: Often, this adverbial phrase is redundant. Consider using an alternative. (FIRST_OF_ALL)
Context: ...). ### Object detection using YOLO-v3 First of all let's deploy the DL model. The deployme...
[misspelling] ~203-~203: Did you maybe mean “buy” or “be”? (BY_BUY)
Context: ...eeYOLO v3in the list. If you cannot by a reason it means that there are some p...
[uncategorized] ~203-~203: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...OLO v3` in the list. If you cannot by a reason it means that there are some problems. ...
[uncategorized] ~212-~212: A comma may be missing after the conjunctive/linking adverb ‘Also’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ... results](/images/yolo_v3_results.jpg) Also it is possible to run a detector for th...
[uncategorized] ~213-~213: A comma may be missing after the conjunctive/linking adverb ‘Thus’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...detector for the whole annotation task. Thus CVAT will run the serverless function o...
[typographical] ~215-~215: Consider adding a comma here. (PLEASE_COMMA)
Context: ...directly into database. For more details please read [the guide][cvat-auto-annotation-u...
[formatting] ~235-~235: Insert a comma after ‘cases’: “In many cases,”? (IN_MOST_CASES_COMMA)
Context: ...several GPU functions at the same time. In many cases it will not work out of the box. For no...
[typographical] ~236-~236: Consider adding a comma here. (FOR_NOW_COMMA)
Context: ... cases it will not work out of the box. For now you should manually schedule different ...
[uncategorized] ~237-~237: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...le different functions on different GPUs and it requires source code modification. N...
[uncategorized] ~277-~277: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... models ### Choose a DL model For the tutorial I will choose a popular AI library with...
[style] ~277-~277: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative. (A_LOT_OF)
Context: ...I will choose a popular AI library with a lot of models inside. In your case it can be y...
[typographical] ~278-~278: At the start of a sentence, a comma is usually required for the expression ‘In “your case,”’. (COMMA_OF_IN_PRPS_CASE)
Context: ...library with a lot of models inside. In your case it can be your own model. If it is base...
[uncategorized] ~281-~281: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...tron2-github] is Facebook AI Research's next generation library that provides state-of-the-art ...
[grammar] ~284-~284: The usual collocation for “Facebook” is “on”. Did you mean “on Facebook”? (IN_FACEBOOK)
Context: ...ch projects and production applications in Facebook. Clone the repository somewhere. I ass...
[style] ~296-~296: Often, this adverbial phrase is redundant. Consider using an alternative. (FIRST_OF_ALL)
Context: ...s Let's run a detection model locally. First of all need to [install requirements][detectro...
[formatting] ~298-~298: Insert a comma after ‘case’: “In my case,”? (IN_MOST_CASES_COMMA)
Context: ...ectron2-requirements] for the library. In my case I have Ubuntu 20.04 with python 3.8.5. ...
[uncategorized] ~332-~332: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...ster_1.jpg/1920px-Cat_poster_1.jpg ``` Finally let's run the DL model inference on CPU...
[uncategorized] ~344-~344: This word is normally spelled with a hyphen. (HARD_CODE_COMPOUND)
Context: ...terpret output of the model only. Let's hard code parameters and remove argparse. Keep on...
[typographical] ~347-~347: Consider adding a comma after ‘Finally’ for more clarity. (RB_LY_COMMA)
Context: ...mmon advice how to minimize some code. Finally you should get something like the code ...
[uncategorized] ~349-~349: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...dictor, and run inference. As the final step it prints all detected bounding boxes w...
[style] ~395-~395: Often, this adverbial phrase is redundant. Consider using an alternative. (FIRST_OF_ALL)
Context: ...xample and try adapting it to our case. First of all let's invent an unique name for the new...
[misspelling] ~396-~396: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’. (EN_A_VS_AN)
Context: ... to our case. First of all let's invent an unique name for the new function: `pth-...
[typographical] ~402-~402: Consider adding a comma after ‘Basically’ for more clarity. (RB_LY_COMMA)
Context: ...It can have several different values. Basically it affects input and output of the func...
[typographical] ~403-~403: At the start of a sentence, a comma is usually required for the expression ‘In “our case,”’. (COMMA_OF_IN_PRPS_CASE)
Context: ... input and output of the function. In our case it hasdetectortype and it means tha...
[uncategorized] ~403-~403: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...on. In our case it hasdetectortype and it means that the integrated DL model c...
[typographical] ~406-~406: Consider adding a comma after ‘Usually’ for more clarity. (RB_LY_COMMA)
Context: ...on only and can have arbitrary value. Usually it has values like OpenVINO, PyTorch, T...
[uncategorized] ~408-~408: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...bels which the model supports. In the case the DL model was trained on MS COCO dat...
[style] ~416-~416: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...language runtime. -spec.eventTimeoutis the global event timeout Next step is ...
[uncategorized] ~417-~417: Possible missing article found. (AI_HYDRA_LEO_MISSING_THE)
Context: ...ntTimeout` is the global event timeout Next step is to describe how to build our se...
[typographical] ~424-~424: At the start of a sentence, a comma is usually required for the expression ‘In “our case,”’. (COMMA_OF_IN_PRPS_CASE)
Context: ...commands to build your docker image In our case we start from Ubuntu 20.04 base image, ...
[grammar] ~426-~426: The word “setup” is a noun. The verb is spelled with a white space. (NOUN_VERB_CONFUSION)
Context: ...eat installation steps which we used to setup the DL model locally with minor modific...
[typographical] ~503-~503: Consider adding a comma here. (FOR_THAT_COMMA)
Context: ...and Common Pitfalls][nuclio-bkms-doc]. After that we need to accept incoming HTTP request...
[formatting] ~597-~597: Insert a comma after ‘cases’: “In most cases,”? (IN_MOST_CASES_COMMA)
Context: ... run the function on the target device. In most cases it will be necessary to modify installa...
[uncategorized] ~643-~643: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...e: GPU has very limited amount of memory and it doesn't allow to run multiple server...
[grammar] ~643-~643: Did you mean “running”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun. (ALLOW_TO)
Context: ...d amount of memory and it doesn't allow to run multiple serverless functions in parall...
[typographical] ~646-~646: Consider adding a comma after ‘Theoretically’ for more clarity. (RB_LY_COMMA)
Context: ...ause scaling to zero feature is absent. Theoretically it is possible to run different functio...
[grammar] ~647-~647: Did you mean “changing”? Or maybe you should add a pronoun? In active voice, ‘require’ + ‘to’ takes an object, usually a pronoun. (ALLOW_TO)
Context: ...ions on different GPUs, but it requires to change source code on corresponding serverless...
[uncategorized] ~653-~653: A comma is probably missing here. (MISSING_COMMA_AFTER_INTRODUCTORY_PHRASE)
Context: ...rless function and want to debug it. Of course you can usecontext.logger.infoor si...
[grammar] ~656-~656: The word “setup” is a noun. The verb is spelled with a white space. (NOUN_VERB_CONFUSION)
Context: ...com/). Please see instructions below to setup your environment step by step. Let's m...
[uncategorized] ~659-~659: A comma may be missing after the conjunctive/linking adverb ‘Otherwise’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...d specify thatmaxWorkerscount is 1. Otherwise both workers will try to use the same p...
[uncategorized] ~660-~660: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...th workers will try to use the same port and it will lead to an exception in python ...
[grammar] ~671-~671: The usual preposition is ‘at’. (IN_THE_END_OF)
Context: ...o a port (e.g. 5678). Insert code below in the beginning of your file with entry point. ```python ...
[uncategorized] ~687-~687: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...anet ``` To debug python code inside a container you have to publish the port (in this t...
[uncategorized] ~688-~688: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...clio deploy command doesn't support that and we have to workaround it using [SSH por...
[grammar] ~688-~688: The word “workaround” is a noun. The verb is spelled with a space. (NOUN_VERB_CONFUSION)
Context: ...and doesn't support that and we have to workaround it using [SSH port forwarding](https://...
[grammar] ~689-~689: An auxiliary verb seems to be missing from this progressive structure. Did you mean “it's using”, “it is using”, or “it was using”? (PRP_VBG)
Context: ... support that and we have to workaround it using [SSH port forwarding](https://www.ssh.c...
[uncategorized] ~694-~694: Possible missing article found. (AI_HYDRA_LEO_MISSING_THE)
Context: ...gsudo systemctl restart ssh.serviceNext step is to install ssh client inside th...
[uncategorized] ~695-~695: Possible missing article found. (AI_HYDRA_LEO_MISSING_A)
Context: ...t ssh.service` Next step is to install ssh client inside the container and run por...
[uncategorized] ~735-~735: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...hould be triggered in Visual Studio Code and it should be possible to inspect variab...
[style] ~761-~761: Often, this adverbial phrase is redundant. Consider using an alternative. (FIRST_OF_ALL)
Context: ...orwarding again._ ### Troubleshooting First of all need to check that you are using the re...
[formatting] ~763-~763: Insert a comma after ‘case’: “In my case,”? (IN_MOST_CASES_COMMA)
Context: ...ecommended version of Nuclio framework. In my case it is1.5.16but you need to check [t...
[formatting] ~784-~784: Insert a comma after ‘case’: “In my case,”? (IN_MOST_CASES_COMMA)
Context: ... model, which doesn't work, is healthy. In my case Inside Outside Guidance is not running....
[formatting] ~842-~842: Consider inserting a comma after an introductory phrase for better readability. (IN_THAT_CASE_COMMA)
Context: ...rror | 0 | 1/1 ```
[formatting] ~862-~862: Consider inserting a comma after an introductory phrase for better readability. (IN_THAT_CASE_COMMA)
Context: ...he previous container for the function. In this case it iseb0c1ee46630. After that the de...
[typographical] ~863-~863: Consider adding a comma here. (FOR_THAT_COMMA)
Context: ...ion. In this case it iseb0c1ee46630. After that the deploying command works as expected...
Additional comments not posted (54)
serverless/pytorch/shiyinzhang/iog/nuclio/function.yaml (1)
Line range hint
1-50: Removal of theframeworkannotation aligns with the PR's goal to streamline responses and metadata.cvat-core/src/ml-model.ts (1)
Line range hint
1-100: Removal of theframeworkgetter method aligns with the PR's goal to streamline model properties.cvat/apps/lambda_manager/views.py (1)
Line range hint
1-1000: Removal offramework,state, andattributesfrom theLambdaFunctionclass and itsto_dictmethod aligns with the PR's goal to streamline lambda function properties.site/content/en/docs/manual/advanced/serverless-tutorial.md (51)
Line range hint
9-9: Consider using a stronger verb to enhance the expression.
[STYLE]- Leveraging the power of computers to solve daily routine problems, fix mistakes, and find information has become second nature. + Utilizing the power of computers to solve daily routine problems, correct mistakes, and find information has become second nature.
Line range hint
25-25: Add a comma after "CVAT" for clarity.
[GRAMMAR]- In CVAT all such DL models are implemented as serverless functions using the [Nuclio][nuclio-homepage] serverless platform. + In CVAT, all such DL models are implemented as serverless functions using the [Nuclio][nuclio-homepage] serverless platform.
Line range hint
33-33: Add a comma before "and" to connect two independent clauses.
[GRAMMAR]- What is a serverless function and why is it used for automatic annotation in CVAT? + What is a serverless function, and why is it used for automatic annotation in CVAT?
Line range hint
37-37: Consider adding a comma after "format" for clarity.
[GRAMMAR]- After that you can upload the annotation file into CVAT. + After that, you can upload the annotation file into CVAT.
Line range hint
38-38: Add a comma after "works" to improve readability.
[GRAMMAR]- It works but it is not user-friendly. + It works, but it is not user-friendly.
Line range hint
48-48: Add a comma after "Thus" for clarity.
[GRAMMAR]- Thus if you deploy a serverless function, the CVAT server can see it and call it with appropriate arguments. + Thus, if you deploy a serverless function, the CVAT server can see it and call it with appropriate arguments.
Line range hint
50-50: Add a comma after "Of course" for clarity.
[GRAMMAR]- Of course there are some tricks how to create serverless functions for CVAT and we will discuss them in next sections of the tutorial. + Of course, there are some tricks how to create serverless functions for CVAT and we will discuss them in next sections of the tutorial.
Line range hint
51-51: Add a comma before "and" to connect two independent clauses.
[GRAMMAR]- ...to create serverless functions for CVAT and we will discuss them in next sections of the tutorial. + ...to create serverless functions for CVAT, and we will discuss them in next sections of the tutorial.
Line range hint
58-58: Add a comma after "support" for clarity.
[GRAMMAR]- To build CVAT with serverless support you need to run `docker compose` command with specific configuration files. + To build CVAT with serverless support, you need to run `docker compose` command with specific configuration files.
Line range hint
85-85: Consider using "Initially" instead of "In the beginning" to avoid wordiness.
[STYLE]- In the beginning you should not have any deployed serverless functions. + Initially, you should not have any deployed serverless functions.
Line range hint
100-100: Add a comma after "time" for clarity.
[GRAMMAR]- During that time a user needs to annotate all individual objects on a video as tracks. + During that time, a user needs to annotate all individual objects on a video as tracks.
Line range hint
101-101: Add a comma after "Basically" for clarity.
[GRAMMAR]- Basically for every object we need to know its location on every frame. + Basically, for every object we need to know its location on every frame.
Line range hint
104-104: Add a comma after "On Linux" for clarity.
[GRAMMAR]- On Linux you can use `serverless/deploy_cpu.sh` auxiliary script, but below we are using `nuctl` directly. + On Linux, you can use `serverless/deploy_cpu.sh` auxiliary script, but below we are using `nuctl` directly.
Line range hint
158-158: Add a comma after "Finally" for clarity.
[GRAMMAR]- Finally you will get bounding boxes. + Finally, you will get bounding boxes.
Line range hint
167-167: Consider rephrasing to avoid redundancy.
[STYLE]- First of all let's deploy the DL model. + Let's begin by deploying the DL model.
Line range hint
203-203: Add a comma after "reason" for clarity.
[GRAMMAR]- If you cannot by a reason it means that there are some problems. + If you cannot by a reason, it means that there are some problems.
Line range hint
212-212: Add a comma after "Also" for clarity.
[GRAMMAR]- Also it is possible to run a detector for the whole annotation task. + Also, it is possible to run a detector for the whole annotation task.
Line range hint
213-213: Add a comma after "Thus" for clarity.
[GRAMMAR]- Thus CVAT will run the serverless function on every frame of the task and submit results directly into database. + Thus, CVAT will run the serverless function on every frame of the task and submit results directly into database.
Line range hint
215-215: Add a comma after "details" for clarity.
[GRAMMAR]- For more details please read [the guide][cvat-auto-annotation-user-guide]. + For more details, please read [the guide][cvat-auto-annotation-user-guide].
Line range hint
235-235: Add a comma after "cases" for clarity.
[GRAMMAR]- In many cases it will not work out of the box. + In many cases, it will not work out of the box.
Line range hint
236-236: Add a comma after "For now" for clarity.
[GRAMR]- For now you should manually schedule different functions on different GPUs and it requires source code modification. + For now, you should manually schedule different functions on different GPUs and it requires source code modification.
Line range hint
237-237: Add a comma before "and" to connect two independent clauses.
[GRAMMAR]- ...functions on different GPUs and it requires source code modification. + ...functions on different GPUs, and it requires source code modification.
Line range hint
277-277: Add a comma after "tutorial" for clarity.
[GRAMMAR]- For the tutorial I will choose a popular AI library with a lot of models inside. + For the tutorial, I will choose a popular AI library with a lot of models inside.
Line range hint
277-277: Consider using "many" instead of "a lot of" to avoid wordiness.
[STYLE]- For the tutorial, I will choose a popular AI library with a lot of models inside. + For the tutorial, I will choose a popular AI library with many models inside.
Line range hint
278-278: Add a comma after "In your case" for clarity.
[GRAMMAR]- In your case it can be your own model. + In your case, it can be your own model.
Line range hint
281-281: Add a hyphen to "next-generation" when used as an adjective.
[GRAMMAR]- ...is Facebook AI Research's next generation library that provides state-of-the-art ... + ...is Facebook AI Research's next-generation library that provides state-of-the-art ...
Line range hint
284-284: Consider rephrasing to correct the preposition usage.
[GRAMMAR]- ...number of computer vision research projects and production applications in Facebook. + ...number of computer vision research projects and production applications on Facebook.
Line range hint
296-296: Consider rephrasing to avoid redundancy.
[STYLE]- First of all need to [install requirements][detectron2-requirements] for the library. + Initially, you need to [install requirements][detectron2-requirements] for the library.
Line range hint
298-298: Add a comma after "In my case" for clarity.
[GRAMMAR]- In my case I have Ubuntu 20.04 with python 3.8.5. + In my case, I have Ubuntu 20.04 with python 3.8.5.
Line range hint
332-332: Add a comma after "Finally" for clarity.
[GRAMMAR]- Finally let's run the DL model inference on CPU. + Finally, let's run the DL model inference on CPU.
Line range hint
344-344: Consider using "hard-code" when used as a verb.
[GRAMMAR]- Let's hard code parameters and remove argparse. + Let's hard-code parameters and remove argparse.
Line range hint
347-347: Add a comma after "Finally" for clarity.
[GRAMMAR]- Finally you should get something like the code below which has fixed config, read a predefined image, initialize predictor, and run inference. + Finally, you should get something like the code below which has fixed config, read a predefined image, initialize predictor, and run inference.
Line range hint
349-349: Add a comma after "step" for clarity.
[GRAMMAR]- As the final step it prints all detected bounding boxes with scores and labels. + As the final step, it prints all detected bounding boxes with scores and labels.
Line range hint
395-395: Consider rephrasing to avoid redundancy.
[STYLE]- First of all let's invent an unique name for the new function. + Let's begin by inventing a unique name for the new function.
Line range hint
396-396: Use "a" instead of "an" before "unique".
[GRAMMAR]- First of all let's invent an unique name for the new function. + First of all let's invent a unique name for the new function.
Line range hint
402-402: Add a comma after "Basically" for clarity.
[GRAMMAR]- Basically it affects input and output of the function. + Basically, it affects input and output of the function.
Line range hint
403-403: Add a comma before "and" to connect two independent clauses.
[GRAMMAR]- In our case it has `detector` type and it means that the integrated DL model can generate shapes with labels for an image. + In our case, it has `detector` type, and it means that the integrated DL model can generate shapes with labels for an image.
Line range hint
406-406: Add a comma after "Usually" for clarity.
[GRAMMAR]- Usually it has values like OpenVINO, PyTorch, TensorFlow, etc. + Usually, it has values like OpenVINO, PyTorch, TensorFlow, etc.
Line range hint
408-408: Add a comma after "In the case" for clarity.
[GRAMMAR]- In the case the DL model was trained on MS COCO dataset and the list of labels correspond to the dataset. + In the case, the DL model was trained on MS COCO dataset and the list of labels correspond to the dataset.
Line range hint
416-416: Consider rephrasing to avoid repetition of "Next step is".
[STYLE]- Next step is to describe how to build our serverless function. + The next step involves describing how to build our serverless function.
Line range hint
417-417: Add "the" before "next step".
[GRAMMAR]- Next step is to describe how to build our serverless function. + The next step is to describe how to build our serverless function.
Line range hint
424-424: Add a comma after "In our case" for clarity.
[GRAMMAR]- In our case we start from Ubuntu 20.04 base image, install `curl` to download weights for our model, `git` to clone detectron2 project from GitHub, and `python` together with `pip`. + In our case, we start from Ubuntu 20.04 base image, install `curl` to download weights for our model, `git` to clone detectron2 project from GitHub, and `python` together with `pip`.
Line range hint
426-426: Correct the verb form for "setup".
[GRAMMAR]- Repeat installation steps which we used to setup the DL model locally with minor modifications. + Repeat installation steps which we used to set up the DL model locally with minor modifications.
Line range hint
503-503: Add a comma after "After that" for clarity.
[GRAMMAR]- After that we need to accept incoming HTTP requests, run inference, reply with detection results. + After that, we need to accept incoming HTTP requests, run inference, reply with detection results.
Line range hint
597-597: Add a comma after "In most cases" for clarity.
[GRAMMAR]- In most cases it will be necessary to modify installation instructions only. + In most cases, it will be necessary to modify installation instructions only.
Line range hint
643-643: Add a comma before "and" to connect two independent clauses.
[GRAMMAR]- GPU has very limited amount of memory and it doesn't allow to run multiple serverless functions in parallel for now using free open-source Nuclio version on the local platform because scaling to zero feature is absent. + GPU has very limited amount of memory, and it doesn't allow running multiple serverless functions in parallel for now using free open-source Nuclio version on the local platform because scaling to zero feature is absent.
Line range hint
646-646: Add a comma after "Theoretically" for clarity.
[GRAMMAR]- Theoretically it is possible to run different functions on different GPUs, but it requires to change source code on corresponding serverless functions to choose a free GPU. + Theoretically, it is possible to run different functions on different GPUs, but it requires changing source code on corresponding serverless functions to choose a free GPU.
Line range hint
653-653: Add a comma after "Of course" for clarity.
[GRAMMAR]- Of course you can use `context.logger.info` or similar methods to print the intermediate state of your function. + Of course, you can use `context.logger.info` or similar methods to print the intermediate state of your function.
Line range hint
656-656: Correct the verb form for "setup".
[GRAMMAR]- Please see instructions below to setup your environment step by step. + Please see instructions below to set up your environment step by step.
Line range hint
659-659: Add a comma after "Otherwise" for clarity.
[GRAMMAR]- Otherwise both workers will try to use the same port and it will lead to an exception in python code. + Otherwise, both workers will try to use the same port, and it will lead to an exception in python code.
Line range hint
660-660: Add a comma before "and" to connect two independent clauses.
[GRAMMAR]- Otherwise, both workers will try to use the same port and it will lead to an exception in python code. + Otherwise, both workers will try to use the same port, and it will lead to an exception in python code.
SpecLad
force-pushed
the
remove-function-fields
branch
from
fe11c0b
to
9660fb7
Compare
* `labels` and `attributes` have been replaced by `labels_v2`. Keeping them around nearly triples the response length. * `framework` hasn't been used by the UI since 3775bc2, and IMO was never useful to begin with. There are no decisions that the UI can take based on this field, so it's essentially just a freeform text field, and we already have a freeform text field - `description`. (Which... the UI doesn't display either. But it could!) Remove the `framework` field from the function descriptions as well, since it has no other purpose. * `state` has, as far I could determine, never been used by the UI. I could see a field like this potentially being useful (e.g. the UI could still display a function, but prevent it from being used if it's unavailable), but since none of that is implemented right now, I see no reason to have this field in the API.
SpecLad
force-pushed
the
remove-function-fields
branch
from
9660fb7
to
6d6116e
Compare
|
* Move rego files into their respective apps (#7806)
This is the promised sequel to #7734. After this change, the `iam` app
will no longer contain any code specific to other apps.
To make this work, the `/api/auth/rules` endpoint will now construct the
OPA bundle from a set of paths, which will be populated by
`load_app_permissions`.
Move OPA test files accordingly. Fortunately, `opa test` accepts
multiple directories, so it is trivial to adapt the testing
instructions.
Make the necessary adaptations to `generate_tests.py` to search for test
generators in every app. The original parameters of `generate_tests.py`
don't really make sense when there are multiple `rules` directory, so
remove them.
Instead, add a new `--apps-dir` parameter. This parameter isn't really
needed to test the open source version of CVAT, but I expect it to be
useful for testing the Enterprise version.
In addition, add some safety checks to `generate_tests.py`:
* Make sure that we find at least one test generator.
* Propagate exceptions from `call_generator` into the main thread.
### How has this been tested?
I tested the updated commands from the documentation manually, and
examined the rules bundle returned by `/api/auth/rules` to ensure that
it still contains all the `.rego` files.
* Fixed incorrect Cloud Storage request by ID (#7823)
* Opening update CS page sends infinite requests when CS id does not exist (#7828)
=
* Fixed duration of 'change:frame' event (#7817)
* Save video if test failed (#7807)
* Modernize Rego syntax (#7824)
Open Policy Agent v0.59 introduced a new directive (`import rego.v1`)
that ensures that the file is compatible with OPA v1 (to be released in
the future).
Add this directive to all Rego files and update the syntax accordingly.
Which involves the following:
* Rewrite all rules to use the `if` keyword, which is now mandatory.
* Where appropriate, use the `in` keyword, which is now available
without a future import. It's not mandatory, but it looks much nicer.
In addition, update Regal to the latest version, which now enforces the
use of `import rego.v1` by default.
* Optimized analytics requests to ClickHouse (#7804)
* Update the Nuclio version (#7787)
Old verison of Nuclio has some vulnerabilities and it needs to be
updated. Function dependencies have also been updated.
The `mask_rcnn` function has been removed because `mask_rcnn` using
python 3.6. In new version of Nuclio python3.6 is no longer supported.
Nuclio officially recommends using python3.9. Running `mask_rcnn` on
python3.9 causes errors within the function and package conflicts.
* Fixed: Cannot read properties of undefined (reading 'addClass') (#7834)
* fix[security]: Disable nginx server signature by default (#7814)
* Enhanced uploading files with tus protocol, enabled retries (#7830)
* Fixed exception when copy/paste a skeleton point (#7843)
* Added ability to call analytics report manually (#7805)
* Use CPU PyTorch for testing the SDK (#7825)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
Not only is the GPU version of PyTorch much bigger than the CPU version,
but it also pulls in CUDA, which is enormous. We don't (and can't) use
any GPU features in our tests, so we don't need the GPU version.
Using the CPU version saves ~4GB of disk space, which is a lot, because
the standard GitHub runners only offer 14 GB.
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- ~~[ ] I have created a changelog fragment~~ <!-- see top comment in
CHANGELOG.md -->
- ~~[ ] I have updated the documentation accordingly~~
- ~~[ ] I have added tests to cover my changes~~
- ~~[ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~
- ~~[ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))~~
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Enhanced the installation process by adding an extra index URL for
PyTorch CPU wheels to improve SDK setup reliability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Update server dependencies (#7845)
* Bump tqdm from 4.60.0 to 4.66.3 in /utils/dicom_converter (#7848)
* Do not allow to remove latest keyframe from UI (#7844)
* Optimized requests to analytics DB, using timestamps, to avoid going trough the whole table (#7833)
* Fix task creation with video file when there are no valid keyframes (#7838)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Fixed an issue where task creation from videos without valid keyframes
could cause errors.
- **New Features**
- Enhanced video stream handling to support videos without keyframes.
- Improved manifest management with new checks for empty states and
better index handling.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* [GSoC2024] Added feature to show tags corresponding to GT job and manual job in a separate row (#7774)
Fixes #7773 and #7749
Added feature to show tags corresponding to GT job and manual job in a
separate row. Along with the tags of the GT job have a mark of '(GT)' in
them.
### How has this been tested?
When we want to see both manual annotations and GT annotations:
<img width="1217" alt="image loading..."
src="https://github.com/cvat-ai/cvat/assets/72168180/362a1728-24f3-43cb-ac4d-1571ebc5faaf">
When we only want to see the annotations for the manual annotations job:
<img width="1217" alt="image loading..."
src="https://github.com/cvat-ai/cvat/assets/72168180/443fbf56-cd86-404b-bd6d-28351738dddf">
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
~- [ ] I have updated the documentation accordingly~
~- [ ] I have added tests to cover my changes~
- [x] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
~- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))~
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Introduced display tags for Ground Truth (GT) and manual jobs in a
separate row, with GT tags marked for easy identification.
- Enhanced tag highlighting in the annotation interface to better
indicate conflicts.
- **Style**
- Implemented new styles for frame tags to improve visual distinction
when highlighted.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Kirill Lakhov <kirill.9992@gmail.com>
Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
* Fixed vertical polylines difficult to select (#7860)
* Make `generate_tests.py` work with relative `--apps-dir` values (#7851)
In #7806 I goofed and made the `--apps-dir` option work only with
absolute paths. This patch fixes that.
* Fixed cannot read property 'annotations' of null (#7857)
* [GSoC2024] Added quality reporting for Tag annotations (#7582)
Fixes #7424
This PR adds quality computations for Tag annotations.
* Avoid fetching a list of shapes/tags from db, optimized fetching tracks (#7852)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Refactor**
- Updated the method for counting objects in analytics reports to
improve accuracy.
- Made internal methods for initializing tags, shapes, and tracks
publicly accessible, enhancing external usability.
- **Bug Fixes**
- Fixed import paths for better module integration and reliability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Prevent losing tracked attributes when moving to a project (#7863)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Improved object tracking by adding a new model
`TrackedShapeAttributeVal` for enhanced performance and accuracy.
- Resolved issue of lost tracked attribute values when moving tasks to
projects.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Prepare release v2.13.0
* Update develop after v2.13.0
* Remove tasks by projectId from state after deleting project (#7854)
* helm-chart: prevent Traefik from ignoring the backend ingress rule (#7859)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
There is a condition that may occur during Kubernetes deployment, where
the frontend service already has an endpoint (i.e. the frontend pod),
but the backend service does not. For example, the backend pod may not
have started yet or the service controller may not have had time to
react to the backend pod.
In this case, when Traefik serves a request with an `/api/...` path, it
will see that it matches the `/api` rule, but since the corresponding
service has no endpoints, it will _skip_ that rule and try other rules.
And since the `/` rule matches everything, it will then route the
request to the frontend.
This is confusing and unhelpful, and more importantly, it makes health
checks return the wrong result. Since the frontend will serve
`index.html` to every request, a request to `/api/server/health/` or
`/api/server/about` will return a 200 code, even though the server isn't
actually up.
Because of this bug, I have observed weird failures in the Helm
workflow, where the "Wait for CVAT to be ready" step completes, but CVAT
is not actually ready. (FYI: The failures I've seen are actually in a
private repo, but the failure condition could occur in this repo too.
It's just more likely in a private repo, because GitHub uses smaller
runners in private repos.)
The fix is simple: use the `allowEmptyServices` Traefik setting, which
disables the rule skipping behavior. With this setting on, Traefik will
return a 503 response for backend URLs until the backend service gains
an endpoint.
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
I deployed the Helm chart, then ran a `kubectl delete deployments.apps
cvat-backend-server` to simulate the server being unavailable. Then I
curled the `/api/server/health/` endpoint.
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- ~~[ ] I have updated the documentation accordingly~~
- ~~[ ] I have added tests to cover my changes~~
- ~~[ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~
- ~~[ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))~~
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Fixed an issue to prevent incorrect 200 OK responses from API
endpoints before backend readiness.
- **New Features**
- Updated Helm chart to support configurations that allow empty services
in the Kubernetes Ingress provider.
- **Documentation**
- Updated version in Helm chart documentation from `0.12.0` to `0.12.1`.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Fixed calculation of metrics for analytics reports (#7144)
* Check UI does not crash if to activate an object while frame fetching (#7873)
* Fix creating chunks with original quality from png images (#7899)
* Update helm (#7894)
Added ability to specify ServiceAccount for backend pods
Removed passing of DJANGO_MODWSGI_EXTRA_ARGS env variable to server pod
Do not set database host and port env variables if they are empty
* fixed server for duplicate attribute names (#7890)
* Fixed object count in analytics for skeletons and tracks (#7883)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Corrected an issue where analytics reported an incorrect count of
objects for skeleton tracks/shapes.
- Fixed a bug where the analytic report consistently showed one less
object for tracks than the actual count.
- **Improvements**
- Enhanced filtering logic for shapes and tracks in analytics, improving
the accuracy of annotation speed metrics.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Fix CI-nightly tests and refactoring cypress config (#7908)
* Fixed analytics report: working time rounding to minimal 1 hour is not applied to annotation speed anymore (#7898)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
Depends on #https://github.com/cvat-ai/cvat/pull/7883
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Corrected an issue where analytic reports showed an incorrect count of
objects for skeleton tracks and shapes.
- **Improvements**
- Renamed metrics related to annotation speed from total to average for
jobs, tasks, and projects.
- Updated descriptions for annotation speed metrics to specify the
number of objects per hour.
- Removed unnecessary clamping function for working time statistics.
These changes enhance the accuracy and clarity of analytic reports,
providing more meaningful insights into annotation speeds and object
counts.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Fixed exception: Cannot read properties of undefined (reading 'onBloc… (#7913)
* Fixed one way to create an empty mask (#7915)
* check creating task with video without valid keyframes
* fix before commands
* remove extra check
* Fixed updating job/task status after changing job state (#7901)
* Array.toReversed replaced by Array.reduceRight because of better comp… (#7916)
* [GSoC2024] Added additional security headers (#7752)
Added security headers for Referrer-Policy, X-Content-Type-Options.
Referring to Issue https://github.com/cvat-ai/cvat/issues/7398, Added
additional security headers. Added to address the deduction in security
score rating third party scanners.
- Referrer-Policy "strict-origin-when-cross-origin";: Limit the referrer
information sent when a user navigates away from the website
- X-Content-Type-Options "nosniff";: Prevent browsers from attempting to
MIME-sniff the content type of a response to reduce risk of XSS and
Content Injection
Co-authored-by: Roman Donchenko <rdonchen@outlook.com>
* Fixed skeleton selection algorithm (#7921)
* add rest api test
* remove extra video file
* remove unused task
* fix video file path
* Ignore ground truth jobs when compute analytics report for a task/project (#7919)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
* Prepare release v2.14.0
* Update develop after v2.14.0
* replace test video
* formatted code
* add copy videos folder
* Update cypress version (#7929)
* Upgrade React and Antd till the latest version (#7466)
* Fixed conflicts highlight crash in case of hidden by `zOrder` objects (#7917)
* Fixed couple of not stable Cypress tests (#7937)
* Fix missing serviceName field in kvrocks (issue #7741) (#7924)
Add the serviceName field to the kvrocks StatefulSet as per the
Kubernetes specification. This change ensures that the service name is
correctly associated with the StatefulSet pods, allowing for proper DNS
resolution and service discovery within the cluster.
Fixes #7741
### Motivation and context
The Helm installation is currently failing as reported in issue #7741
### How has this been tested?
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Resolved the issue of a missing `serviceName` field in `kvrocks`,
ensuring proper configuration and improved stability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Fix login when email domain contains capital symbols and user was created after invitation to some org (#7906)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved email creation process to ensure the use of the normalized
email from the user object, enhancing data consistency and reducing
errors.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Fixed .ant-modal-wrapper kept after closing saving modal (#7948)
* use other method to get path
* Fix dataset downloading (#7864)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
This PR addresses several problems:
- when requesting a dataset download, it's possible to get the 500 error
with the message "The result file does not exist in export cache", which
isn't expected for this request
- when downloading the dataset the same error can be obtained if the
file is requested right before the cache expiration
- there are several
[TOCTOU](https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use)
bugs related to dataset cache file existence checks
- under some conditions, it's possible that the export job is never
started
- the finished RQ jobs were removed automatically on result reporting
(after the client requested the result). This made it hard to debug
problems for admins, as the jobs were often removed already
This PR fixes the problems by the following:
- introduced dataset cache file locking (via redis) during reading,
writing, and removal
- the 500 error is changed to automatic reexporting attempt on export
status request
- the 500 error is changed to 404 when the file is not available for
downloading
- the exported files are now have different names for each instance
update time
- the lifetime of the exported files is now automatically prolonged on
each export request for the file (given the export is still valid)
- the deferred export jobs are now checked to have ghost dependencies.
If so, the requested job is restarted
- added several environment variables for configuration
- <s>finished RQ export jobs are not removed automatically on result
retrieval. Now, they just use the export cache lifetime instead (should
be continued in another PR)</s>
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Improved reliability of file handling during export and cleanup
processes.
- Introduced new functionality for managing export cache locks and
directories.
- **Bug Fixes**
- Addressed race conditions in concurrent export and cleanup operations.
- **Dependencies**
- Updated multiple packages to their latest versions for enhanced
security and performance:
- `cryptography` to `42.0.7`
- `django` to `4.2.13`
- `django-health-check` to `3.18.2`
- `freezegun` to `1.5.1`
- `jinja2` to `3.1.4`
- `limits` to `3.12.0`
- `lxml` to `5.2.2`
- `orjson` to `3.10.3`
- Added `pottery` version `3.0.0`
- Updated `tqdm` to `4.66.4`
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Fixed working time lost in click:element events (#7942)
* Aborted enabling black linter onsave in vscode (#7956)
* Delete extra comma (#7957)
* Fix a non-deterministic webhook test (#7952)
`test_two_project_webhooks_intersection` is supposed to trigger each
webhook once. However, the first one of these webhooks actually gets
triggered twice, because creating a task causes the project's
`updated_date` to be bumped, which triggers an `update:project` event.
The test still passes a lot of the time (I guess because the second
delivery doesn't appear immediately?), but sometimes it fails. It's very
easy to make it fail consistently, though - just add a `sleep(5)` before
the `get_deliveries` calls.
Fix this by changing the first webhook's second event to something that
will not be triggered.
* Improved `DatasetNotFound` error message (#7923)
The recent changes enhance the dataset import functionality across various dataset formats in the CVAT application by integrating specific importers from the Datumaro library. The updates streamline the detection of datasets, improve error handling, and introduce new tests to ensure robustness against incorrect file structures during import operations.
* Fix automatic `tag` annotation support (#7839)
* Update packages with vulnerability (#7951)
* Cannot set properties of undefined (setting 'serverID') (#7949)
* Fixed some deprecation warnings (#7970)
* Added license information regarding '/serverless' directory (#7967)
* Stabilized the cypress test for fix CI-nightly runs (#7966)
* Squashed `zoom:image` and `send:exception` client events (#7953)
* Fix memory consumption when exporting to azure blob storage (#7960)
Fix memory consumption when exporting to azure blob storage
* Fixed several issues related to creating tasks with cloud data (#7969)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
@coderabbitai summary
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [x] I have added tests to cover my changes (*partially*)
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Improved media download performance with parallel downloading.
- Enhanced file handling with the new `NamedBytesIO` class.
- Added support for specifying stop frames in task manifest generation.
- Enhanced `DatasetImagesReader` to handle generator sources.
- **Performance Improvements**
- Optimized image download methods to use threading for faster
processing.
- **Configuration**
- Introduced new settings for maximum threads and files per thread in
cloud data downloading.
These updates enhance the flexibility, performance, and configurability
of media handling and downloading in the application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Using dedicated event to store working time (#7958)
- Parsing JSON payloads to get `working_time` in general leads to low
performance in Clickhouse requests. This patch will not fix it right
now, but with this patch, after a period of time we may switch to new
quick approach to calculate working time.
- There will not be a lot of `send:working_time` events, we may store
this scope of events for a longer time (e.g. 5 years instead of one by
default).
- Finally storing working time in such events like `click:element` or
`send:exception`, or `debug:info` seems not logical.
- Also, the history showed, that as result in different bugs, these
events may sometime lose information about `job_id`, `task_id`, etc.
Resolved #7884
* Update README.md (#7980)
* Check non-existent cloud storage update page (#7972)
* Annotation interface documentation updated (#7947)
* Bump requests from 2.31.0 to 2.32.2 in /tests/python (#7954)
* Updated icon (#7981)
* Fixed layout on create cloud storage page (#7985)
* Prepare release v2.14.1
* Update develop after v2.14.1
* Fixed: Queued jobs are not considered in deferring logic (#7907)
* Stabilized the cypress test for fix CI-nightly runs 2 (#7971)
* Update datumaro format description (#7992)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
Skeletons are not supported in this format
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Documentation**
- Updated the `Datumaro 1.0` format to support `Tags` instead of
`Tracks`.
- Expanded documentation to include support for additional annotation
types like Polylines, Masks, Points, Cuboids, and Tags in both export
and import operations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Fixed ImageBitmap memory leak (#7995)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
Resolved #7909
Resolved #7850
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Addressed a significant memory leak issue by ensuring `ImageBitmap`
objects are properly closed after use.
- Updated various components to handle cleanup and termination of
workers and instances correctly, preventing potential resource leaks.
- **Version Updates**
- Updated `cvat-canvas` to version 2.20.3.
- Updated `cvat-core` to version 15.0.6.
- Updated `cvat-data` to version 2.1.0.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Updated documentation (one item was missing in the list of events saving triggers) (#8001)
* Prepare release v2.14.2
* Update develop after v2.14.2
* Rename kvrocks port (#8010)
Fix connection error issue in case of istio usage:
https://istio.io/v1.0/docs/setup/kubernetes/spec-requirements/#:~:text=Named%20ports%3A%20Service%20ports%20must,but%20name%3A%20http2foo%20is%20not.
* Fixed login with token without next parameter (#7999)
* Increased server health check timeout (#7993)
* Fixed: Cannot read properties of null (reading 'draw') (#7997)
* Remove unnecessary fields from the `/api/lambda/functions` response (#8004)
Remove several fields that haven't been used for one reason or another:
* `labels` and `attributes` have been replaced by `labels_v2`. Keeping
them around nearly triples the response length.
* `framework` hasn't been used by the UI since #5635, and IMO was never
useful to begin with. There are no decisions that the UI can take based
on this field, so it's essentially just a freeform text field, and we
already have a freeform text field - `description`. (Which... the UI
doesn't display either. But it could!)
Remove the `framework` field from the function descriptions as well,
since it has no other purpose.
* `state` has, as far I could determine, never been used by the UI. I
could see a field like this potentially being useful (e.g. the UI could
still display a function, but prevent it from being used if it's
unavailable), but since none of that is implemented right now, I see no
reason to have this field in the API.
* Fixed exception: State cannot be updated during editing, need to finish current editing first (#8019)
* Check creating cloud storage without manifest file (#7984)
* Number of Org Members (#8015)
Updated number of members
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),
[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))
### License
- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
Feel free to contact the maintainers if that's a concern.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Documentation**
- Updated details for the Solo and Team plans on CVAT.ai:
- Solo Plan: Adjusted the number of members allowed from "up to 3
members" to "up to 2 members".
- Team Plan: Adjusted the number of members required to pay for from "4
seats (3 annotators + 1 organization owner)" to "3 seats (2 annotators +
1 organization owner)".
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* Merge pull request from GHSA-q684-4jjh-83g6
S3 storages support user-specified endpoint URLs, and Azure storages support
user-specified connection strings (which can contain endpoint URLs), so they
are susceptible to SSRF. Make S3 and Azure requests go through smokescreen
to fix this.
AFAIK, there is no way to configure a custom URL for Google Cloud storages,
so those aren't vulnerable.
Co-authored-by: Nikita Manovich <nikita@cvat.ai>
* Merge pull request from GHSA-jpf9-646h-4px7
* Mitigate a CSRF vulnerability in export and backup-related endpoints
While Django has built-in CSRF protection (which we use), it does not cover
GET requests, and AFAICS, there is no way to force it to do that.
Unfortunately, the many endpoints that initiate dataset exports and backups
do accept GET requests _and_ initiate side effects, making them susceptible.
The proper fix for this issue would be to redesign those endpoints to use
POST requests, but a) that's more complicated, and b) we should still keep
the old endpoints for backwards compatibility.
So apply a less proper fix, which is to disable session authentication for
the affected endpoints. It's a bit complex, because in some cases
(particularly when `action=download`) we _need_ session authentication to
work, because the UI redirects the user to such endpoints.
In addition, modify the handling logic for these endpoints in order to
ensure that when `action=download`, no side effects are triggered.
Previously, `action=download` would still queue an RQ job if none existed.
Even after this, `action=download` will still have two small side effects:
* An existing RQ job will be deleted if its results are out of date.
I don't think this is a problem, because such a job cannot be used anyway.
* A completed RQ job will be deleted too. This is a problematic design,
but I don't think an attacker can achieve anything by exploiting this. If
an attacker maliciously redirects the user to an `action=download` URL,
then they'll just download the export/backup as usual.
Some tests were making export requests incorrectly, so fix them.
* Add test for the CSRF workaround
* Prepare release v2.14.3
* Update develop after v2.14.3
* Remove `ModelKind.CLASSIFIER` (#8011)
I'd like the "kind" field in the API to identify the function's
"signature", or the types of values it receives as input and produces as
output. Classifiers have the same signature as detectors, so
`classifier` is a redundant value.
Besides improving semantic purity, removing this redundant value
simplifies the UI code.
The only meaningful difference between how the UI handles classifiers,
as compared to detectors, is that it shows the word "classifier" in the
model modal, which can be helpful. But we can achieve the same thing by
examining the function's `return_type` field. This lets us give a
special label to segmentation functions, as well.
"classifier" can't actually be returned by `/api/lambda/functions`, but
it _can_ be returned by the RoboFlow/Hugging Face function API in CVAT
Enterprise. So we'll need a small compatibility shim to transform this
value to "detector" until I fix that API to stop returning it too.
* Change minio host server definition (#8032)
* Stop editing when n key pressed (#7922)
* Allowed editing in single shape annotation mode (#8017)
* Fix server cache cleanup for backups and events (#8040)
In #7864 the cache cleanup function was updated. The function was not
supposed to be called for anything except datasets, but it was called
for backups and events. This PR changes these clients to use their own
functions.
- Fixed `ValueError: Couldn't parse filename components in
'c71eba87-0914-4ccb-b883-a1bf1612fbf8.csv'` errors
* CVAT Architecture documentation update (#8031)
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->
<!-- Provide a general summary of your changes in the Title above -->
### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](
https://help.githu…
Motivation and context
Remove several fields that haven't been used for one reason or another:
labelsandattributeshave been replaced bylabels_v2. Keeping them around nearly triples the response length.frameworkhasn't been used by the UI since New models UI #5635, and IMO was never useful to begin with. There are no decisions that the UI can take based on this field, so it's essentially just a freeform text field, and we already have a freeform text field -description. (Which... the UI doesn't display either. But it could!)Remove the
frameworkfield from the function descriptions as well, since it has no other purpose.statehas, as far I could determine, never been used by the UI. I could see a field like this potentially being useful (e.g. the UI could still display a function, but prevent it from being used if it's unavailable), but since none of that is implemented right now, I see no reason to have this field in the API.How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Refactor
Documentation
framework: pytorchentry for the RetinaNet R101 detector.