-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved types corresponding to export actions
#8122
Conversation
WalkthroughThe changes encompass updating type definitions and enhancing type safety across various parts of the CVAT-UI codebase. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- cvat-ui/src/actions/export-actions.ts (2 hunks)
- cvat-ui/src/components/export-dataset/export-dataset-modal.tsx (1 hunks)
- cvat-ui/src/reducers/index.ts (7 hunks)
Additional comments not posted (7)
cvat-ui/src/actions/export-actions.ts (4)
28-28
: Improved Type SafetyThe parameter type has been updated to
ProjectOrTaskOrJob
, enhancing type safety and clarity.
31-31
: Improved Type SafetyThe parameter type has been updated to
ProjectOrTaskOrJob
, enhancing type safety and clarity.
64-64
: Improved Type SafetyThe parameter type has been updated to
ProjectOrTaskOrJob
, enhancing type safety and clarity.
67-67
: Improved Type SafetyThe parameter type has been updated to
ProjectOrTaskOrJob
, enhancing type safety and clarity.cvat-ui/src/components/export-dataset/export-dataset-modal.tsx (1)
96-97
: Prevent Potential ErrorsThe conditional check for
instance
before dispatching thecloseExportDatasetModal
action prevents potential errors wheninstance
is not defined.cvat-ui/src/reducers/index.ts (2)
115-131
: Improved Type SafetyThe
modalInstance
type has been updated fromany | null
toProject | Task | Job | null
, enhancing type safety and clarity.
Line range hint
140-164
:
Improved Type SafetyThe
modalInstance
type has been updated fromany | null
toProject | Task | Job | null
, enhancing type safety and clarity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8122 +/- ##
===========================================
- Coverage 83.62% 83.27% -0.35%
===========================================
Files 383 389 +6
Lines 40507 41274 +767
Branches 3830 3855 +25
===========================================
+ Hits 33873 34370 +497
- Misses 6634 6904 +270
|
Motivation and context
Changed some
any
to correct types, removed unused fileHow has this been tested?
Checklist
develop
branch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Improvements
Refactor
Task
toProject
in various parts of the codebase for better alignment with updated data models.