Fixed server code 500 -> 400 when user input is not correct #8280
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change enhances the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- cvat/apps/lambda_manager/views.py (1 hunks)
Additional comments not posted (1)
cvat/apps/lambda_manager/views.py (1)
346-350: Verify the new validation logic for skeleton sublabels.The validation logic ensures that sublabels are present for skeleton types. This is a good enhancement for data integrity. However, verify that this change does not introduce any unintended side effects or exceptions in other parts of the codebase that rely on this function.
Verification successful
New validation logic for skeleton sublabels verified.
The
validate_labels_mappingfunction, which includes the new validation logic for skeleton sublabels, is called in a consistent context within the same file. There are no indications of unintended side effects in other parts of the codebase. The change appears to be safe and well-contained.
- Calls to
validate_labels_mappingare found incvat/apps/lambda_manager/views.py.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the new validation logic for skeleton sublabels. # Test: Search for all calls to `validate_labels_mapping`. Expect: Ensure that all calls handle the new validation logic properly. rg --type python -A 5 $'validate_labels_mapping'Length of output: 78
Script:
#!/bin/bash # Description: Verify the impact of the new validation logic for skeleton sublabels. # Test: Search for all calls to `validate_labels_mapping`. Expect: Ensure that all calls handle the new validation logic properly. rg --type py -A 5 'validate_labels_mapping'Length of output: 1511
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8280 +/- ##
===========================================
- Coverage 83.36% 83.36% -0.01%
===========================================
Files 390 390
Lines 41549 41551 +2
Branches 3860 3860
===========================================
+ Hits 34637 34638 +1
- Misses 6912 6913 +1
|
Motivation and context
How to reproduce: send automatic annotation request for a skeleton without specifying any sublabels, e.g:
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes