-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #8308
Update dependencies #8308
Conversation
WalkthroughThe recent changes enhance the Docker configurations and update several dependencies in the application. Significant updates include upgrading the Go version in the Dockerfile, enhancing the NGINX base image for the UI, and incrementing various library versions in the requirements files. These modifications aim to improve performance, security, and overall reliability of the application while maintaining consistency in the Docker setup. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- Dockerfile (2 hunks)
- Dockerfile.ui (1 hunks)
- cvat/requirements/base.txt (9 hunks)
- cvat/requirements/development.txt (1 hunks)
- cvat/requirements/production.txt (1 hunks)
Files skipped from review due to trivial changes (2)
- cvat/requirements/development.txt
- cvat/requirements/production.txt
Additional comments not posted (4)
Dockerfile.ui (1)
37-38
: Upgrade to a newer NGINX image version.The update to
nginx:1.26.1-alpine3.19-slim
is approved. This change may provide performance improvements and security patches. The slim variant can also reduce the image size, enhancing deployment efficiency.Dockerfile (2)
4-4
: Standardize alias casing.The change from
as
toAS
in the alias for the build stage is a stylistic improvement for consistency. This change does not affect functionality.
87-87
: Upgrade Go version.The update to
golang:1.23.0
is approved. This change may introduce new features or optimizations. Ensure compatibility with any breaking changes introduced in this version.cvat/requirements/base.txt (1)
38-38
: Approve dependency updates.The updates to the dependencies are approved. These may include bug fixes, performance improvements, or new features. Ensure compatibility with the rest of the codebase.
Also applies to: 72-72, 130-130, 141-141, 151-151, 173-173, 199-199, 272-272, 358-358
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8308 +/- ##
===========================================
- Coverage 83.35% 83.33% -0.02%
===========================================
Files 391 391
Lines 41556 41556
Branches 3839 3839
===========================================
- Hits 34639 34632 -7
- Misses 6917 6924 +7
|
Updated:
backend python packages
golang image
frontend nginx base image
Motivation and context
How has this been tested?
Checklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have linked related issues (see GitHub docs)- [ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes
Chores