Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cursor to pointer on hover for username #8317

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

smit9924
Copy link
Contributor

@smit9924 smit9924 commented Aug 18, 2024

Motivation and context

As cursor don't turn into pointer so it is very misleading to the end user. They might confuse whether this is click able button or not. (fix #8316)

How has this been tested?

Run all test cases also check related UI manually to insure double check.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features
    • Enhanced user interface by indicating interactivity of the user dropdown menu with a new pointer cursor style.

Copy link
Contributor

coderabbitai bot commented Aug 18, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent update enhances the user interface of the CVAT application by adding a cursor: pointer; style to the dropdown menu in the header. This subtle change improves user experience by visually indicating that the dropdown is interactive, encouraging users to engage with the element. Overall, the modification focuses on usability without altering any underlying functionality.

Changes

File Change Summary
cvat-ui/src/components/header/styles.scss Added cursor: pointer; to .cvat-header-menu-user-dropdown to indicate it is clickable.

Poem

In the header, a change so neat,
A pointer for users, a friendly greet! 🐇
Click away, let the dropdown show,
A world of options, just a click to go!
With each interaction, joy will bloom,
Enhancing our interface, dispelling the gloom! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a69e122 and d99ca6a.

Files selected for processing (1)
  • cvat-ui/src/components/header/styles.scss (1 hunks)
Files skipped from review due to trivial changes (1)
  • cvat-ui/src/components/header/styles.scss

@smit9924 smit9924 changed the title fix: update cursor to be pointer on hover for username(#8316) fix: update cursor to be pointer on hover for username #8316 Aug 18, 2024
@smit9924 smit9924 changed the title fix: update cursor to be pointer on hover for username #8316 UI: on hover the username cursor don't turn into pointer even is clickable elements #8316 Aug 18, 2024
@smit9924 smit9924 changed the title UI: on hover the username cursor don't turn into pointer even is clickable elements #8316 fix: update cursor to pointer on hover for username Aug 18, 2024
@smit9924
Copy link
Contributor Author

@bsekachev can you please let me know whether any changes required in this PR??

@bsekachev bsekachev requested review from klakhov and removed request for bsekachev September 16, 2024 08:46
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (e929a3d) to head (df5e5a1).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8317   +/-   ##
========================================
  Coverage    83.10%   83.10%           
========================================
  Files          397      397           
  Lines        41907    41907           
  Branches      3882     3882           
========================================
+ Hits         34825    34826    +1     
+ Misses        7082     7081    -1     
Components Coverage Δ
cvat-ui 78.45% <ø> (ø)
cvat-server 87.23% <ø> (+<0.01%) ⬆️

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!

@klakhov klakhov merged commit ace55bf into cvat-ai:develop Sep 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: on hover the username cursor don't turn into pointer even is clickable elements
3 participants