updating datumaro #8370
updating datumaro #8370
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes involve updates to various dependency specifications and modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API
participant Comparator
User->>API: Request dataset comparison
API->>Comparator: Compare datasets
Comparator->>Comparator: Check rotation attribute
Comparator->>Comparator: Validate elements field
Comparator-->>API: Return comparison result
API-->>User: Send comparison result
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- cvat/apps/dataset_manager/tests/test_rest_api_formats.py (2 hunks)
- cvat/requirements/base.in (1 hunks)
- cvat/requirements/base.txt (7 hunks)
- cvat/requirements/development.txt (1 hunks)
- cvat/requirements/production.txt (1 hunks)
Files skipped from review due to trivial changes (3)
- cvat/requirements/base.txt
- cvat/requirements/development.txt
- cvat/requirements/production.txt
Additional comments not posted (3)
cvat/requirements/base.in (1)
9-9: Verify the impact of the updated dependency.The
datumaropackage has been updated to a new commit hash. Ensure that the changes introduced in the new commit do not break any existing functionality and are compatible with the current codebase.Run the following script to check for any breaking changes or compatibility issues:
cvat/apps/dataset_manager/tests/test_rest_api_formats.py (2)
104-104: Stricter comparison logic: Removedignored_fieldsparameter.The
ignored_fieldsparameter has been removed from theExactComparatorinstantiation, making the comparison logic stricter by not ignoring the "elements" field. Ensure that this change does not cause unintended issues in dataset comparisons.Verify that all tests pass and no issues arise from this change.
Line range hint
104-110: Removed skeleton elements comparison block.The code block that handled the comparison of skeleton elements has been removed. This change might affect the validation of datasets with skeleton annotations. Ensure that this change does not cause unintended issues in dataset comparisons.
Verify that all tests pass and no issues arise from this change.
Eldies
force-pushed
the
dl/yolo8-update
branch
from
01082de
to
dbcac0d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8370 +/- ##
===========================================
- Coverage 83.62% 83.45% -0.17%
===========================================
Files 393 395 +2
Lines 41640 41826 +186
Branches 3841 3881 +40
===========================================
+ Hits 34820 34907 +87
- Misses 6820 6919 +99
|
Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
|
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes
Chores