Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing skeleton track project export #8423

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Conversation

Eldies
Copy link
Contributor

@Eldies Eldies commented Sep 10, 2024

Motivation and context

Fixes #8397

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Enhanced frame selection logic for shape conversion in the annotation process.
    • Introduced a new "skeleton track" section in the annotations JSON structure to support complex tracking scenarios.
    • Added functionality to retrieve tasks associated with specific projects via a new private method.
  • Bug Fixes

    • Improved type clarity for the include_empty parameter in the group_by_frame method.
  • Tests

    • Added a new test for validating the upload of annotations for tasks of type "track."

Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request enhance the dataset manager's functionality by refining the logic for frame inclusion in annotations, improving type declarations for method parameters, and adding new JSON structures for skeleton tracks. Additionally, new methods and tests have been introduced to support the retrieval and validation of tasks related to projects, ensuring better handling of annotation exports.

Changes

Files Change Summary
cvat/apps/dataset_manager/annotation.py Modified to_shapes method to refine how included_frames are determined for track_elements.
cvat/apps/dataset_manager/bindings.py Updated group_by_frame method signature to explicitly declare include_empty as a bool.
cvat/apps/dataset_manager/tests/assets/annotations.json Added a new "skeleton track" section with detailed tracking shape entries.
cvat/apps/dataset_manager/tests/test_rest_api_formats.py Introduced _get_tasks method for fetching project tasks and test_api_v2_dump_upload_annotations_with_objects_type_is_track for validating track annotations.

Assessment against linked issues

Objective Addressed Explanation
Ensure all exports show points of track or shape skeletons (#8397)
Evaluate dangling tracks per image during project data export (#8397) Unclear if the export logic fully addresses this.

🐇 In the fields where shapes do play,
Tracks and skeletons now find their way.
With clearer paths and tests anew,
Our annotations shine bright and true!
Hops of joy for changes made,
In data's dance, we won't be swayed! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (29b33c3) to head (d26b035).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8423      +/-   ##
===========================================
+ Coverage    83.12%   83.17%   +0.04%     
===========================================
  Files          397      397              
  Lines        41888    41891       +3     
  Branches      3879     3879              
===========================================
+ Hits         34821    34842      +21     
+ Misses        7067     7049      -18     
Components Coverage Δ
cvat-ui 78.60% <ø> (+0.04%) ⬆️
cvat-server 87.23% <100.00%> (+0.04%) ⬆️

Copy link

sonarcloud bot commented Sep 12, 2024

@SpecLad SpecLad merged commit 76b639e into develop Sep 12, 2024
34 checks passed
@SpecLad SpecLad deleted the dl/fix-skeleton-project-export branch September 12, 2024 10:23
bschultz96 pushed a commit to bschultz96/cvat that referenced this pull request Sep 12, 2024
@cvat-bot cvat-bot bot mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project dataexport showing no track skeletons
3 participants