Merge pull request #110 from cvxgrp/tschm-patch-1

Update basic.yml
cvxgrp · Jun 16, 2024 · 3bb218a · 3bb218a
2 parents 3471bb5 + be9a03f
commit 3bb218a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/.github/workflows/basic.yml b/.github/workflows/basic.yml
@@ -18,9 +18,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: cvxgrp/.github/actions/test@main
-      with:
-        python-version: '3.10'
+    - uses: cvxgrp/.github/actions/coverage@main
 
     - name: Coveralls GitHub Action
       uses: coverallsapp/github-action@v2

diff --git a/tests/test_frontier.py b/tests/test_frontier.py
@@ -70,8 +70,4 @@ def test_frontiers(n, resource_dir):
 
     assert np.sum(f_bailey.frontier[-1].weights) == pytest.approx(1)
     assert np.sum(f_markowitz.frontier[-1].weights) == pytest.approx(1)
-
-    assert len(f_bailey.frontier) == len(f_markowitz.frontier)
-    print(f_bailey.max_sharpe[0], f_markowitz.max_sharpe[0])
-    for pt_bailey, pt_markowitz in zip(f_bailey.frontier, f_markowitz.frontier):
-        assert np.allclose(pt_bailey.weights, pt_markowitz.weights, atol=1e-5)
+    assert f_bailey.max_sharpe[0] == pytest.approx(f_markowitz.max_sharpe[0])