Disable sort optimization for HALF_FLOAT (opensearch-project#10999) (o…

…pensearch-project#11005) Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
cwperks · Oct 30, 2023 · ac4de44 · ac4de44
1 parent 3549fb3
commit ac4de44
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ### Removed
 
 ### Fixed
+- [BUG] Disable sort optimization for HALF_FLOAT ([#10999](https://github.com/opensearch-project/OpenSearch/pull/10999))
 
 ### Security
 
-[Unreleased 2.11]: https://github.com/opensearch-project/OpenSearch/compare/2.11...2.11
+[Unreleased 2.11]: https://github.com/opensearch-project/OpenSearch/compare/2.11...2.11
+
diff --git a/server/src/main/java/org/opensearch/index/fielddata/IndexNumericFieldData.java b/server/src/main/java/org/opensearch/index/fielddata/IndexNumericFieldData.java
@@ -242,7 +242,7 @@ private XFieldComparatorSource comparatorSource(
                 assert !targetNumericType.isFloatingPoint();
                 source = new IntValuesComparatorSource(this, missingValue, sortMode, nested);
         }
-        if (targetNumericType != getNumericType()) {
+        if (targetNumericType != getNumericType() || getNumericType() == NumericType.HALF_FLOAT) {
             source.disableSkipping(); // disable skipping logic for cast of sort field
         }
         return source;