Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error look when a required field is not filled in. #29

Closed
ilovan opened this issue Jul 27, 2018 · 4 comments
Closed

Improve error look when a required field is not filled in. #29

ilovan opened this issue Jul 27, 2018 · 4 comments

Comments

@ilovan
Copy link
Contributor

ilovan commented Jul 27, 2018

Expected Behaviour

Red highlight is ok

Empty dialog bubble is not: maybe have it say "required field"? Also, could you make it so that the check for the required fields happens only when the user tries to submit the entity?
People may want to fill in the form asynchronously, which now causes these error messages to pop up as soon as you try to fill in a field that is below a required field ahead of the required field.

Current Behaviour

image

@ajmacdonald
Copy link
Contributor

Caused by Semantic-Org/Semantic-UI#6439

@ajmacdonald
Copy link
Contributor

Temporary override is in place, until they update their repo

@ilovan
Copy link
Contributor Author

ilovan commented Aug 15, 2018

Thanks @ajmacdonald , I confirm that the override is working.

@ilovan ilovan closed this as completed Aug 15, 2018
@ajmacdonald
Copy link
Contributor

238df40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants