-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Label] Basic label has same colored background since 2.3.2 #6439
Comments
Caused by #6220 |
same issue |
I'm also experiencing this issue on a few deployments (e.g. jobson-ui). Seems It's visible on the current SemanticUI documentation site (see |
same issue. I installed semantic ui 2.3.2 via npm in my angular app |
@basicBackground equals to Since specific attribute have precedence over combined, a possible solution would be adding a new variable for specific background attribute
for
in label.less. |
Same issue |
Same issue. thanks |
I'll fix in patch |
Same problem for 2.3.3@llturro Thanks for your comment. I fixed in a more simple way. /* Basic */
@basicBackground: @white; |
Are there any updates on this? |
@fridzema Fixed in FUI https://github.com/hammy2899/Fomantic-UI |
This is still an issue in 2.3.3.
IMO this is high priority. |
As noted by hammy2899, it fixed in https://github.com/hammy2899/Fomantic-UI . For those interested in a patch, I found the commit reference: It's part of Version 2.4.0, released June 19, 2018: |
Is there a Formantic-React? |
@james-ff No but you can use fomantic with semantic react you just can use any of the new features which require implementation. Can we also keep this issue on topic. If you have any questions about fomantic feel free to open an issue on the fomantic repo or join our discord. |
"No but you can use fomantic with semantic react you just can use any of the new features which require implementation." I'm not quite sure what you mean here. If you can use fomantic with this library https://github.com/Semantic-Org/Semantic-UI-React (assuming you mean using just fomantic css), how? and where do I find the info on how to? (I can't find anything on the repo linked). To be clear, I'm using https://github.com/Semantic-Org/Semantic-UI-React and have been required to come to this library to discuss this issue because the issue can't be fixed in the react version, as the css is determined here. Semantic-Org/Semantic-UI-React#2995. |
@james-ff I mean any bugs which are fixed in fomantic like this label one will be fixed in if you use fomantic with semantic-ui-react however if you want to use any new features which require new classes you will need to add them manually with I have also just made a CSS only repo for easy integrations like react. https://github.com/fomantic/Fomantic-UI-CSS I hope this clears things up if not please make an issue on the fomantic repo. |
Any plans to make a new release of |
It would be great ! There has been no release since July 9... the problem is quite urgent, this type of label is often used for error messages on forms for example. Can a Semantic-UI staff member tell us more about the date of the next release ? Thanks ;) |
@J2BB There is no exact date when this will be fixed, this will be fixed when @jlukic merges the PR and creates a release. @ThiefMaster The CSS repo will be updated once this repo gets a new release. |
Any workaround for web app? I use this semantic via the CDN. |
@awansoekamto, I added the following code in my main css file: // WORKAROUND - Fixing basic labels text colors in semantic-ui v2.3.1+
.ui.basic.label {
background: none #FFFFFF !important;
} I think it worth to mention that this stylesheet is loaded by last in my app. |
Thank you so much! |
I've fixed this in |
|
I just released |
Awesome! Thanks team. |
Perfect. Everything works!!! Thank you. |
Hi, Coming from Semantic UI React and Next.js. Easiest way to use this library for my case is via CDN, can we get 2.4.0 added to the CDN? |
Steps
https://semantic-ui.com/elements/label.html -> Basic
Expected Result
up to version 2.3.1
Actual Result
colored background, if color was defined
Version
2.3.2
Testcase
https://semantic-ui.com/elements/label.html -> Basic
The text was updated successfully, but these errors were encountered: