Fix for issue where metadata dataset.name disappeared #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It pains me that this one is so weird, but this pull request looks to be the state of the art for fixing the issue, so let's go with it! I'm just going to include some of the links that you sent to me previously about the issue for context: apollographql/apollo-client#3928 |
|
WoIf it's a dirty fix/workaround, is it worth annotating the code with some comments (maybe even links to the same appolographql issues you mention here) for future readers to understand why something weird happened? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ongoing issue with apollo, it seems. I've found a bit of a workaround, but it still causes the dataset name to flash. It's the best I've got for now.