Support KUBECONFIG environment variable #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KUBECONFIG environment variable provides a convenient alternative to the kubeletctl --config flag.
zmedico
force-pushed
the
support-KUBECONFIG-environment-variable
branch
from
663f67d to
6b0c782
Compare
|
Thanks for the contribution! :) |
|
It seems to work, the only issue is when someone provides a corrupted config file to KUBECONFIG or someone just want to use an anonymous request without the KUBECONFIG environment variable. I can add it and change the panic message and maybe add flag to ignore the KUBECONFIG environment variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KUBECONFIG environment variable provides a convenient alternative
to the kubeletctl --config flag.