Fix bug with marshling: "Failed to print unexpected end of JSON input" #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Unmarshal` function used wrong parameter `sDec` instead of the new one `newDec`. Second issue was that some tokens are being set with bad base64. For example: 1234 in base64 is: "MTIzNA==" If you will remove the "==" in some places you will still get "1234" but in the Go function it remove the "4". So using "MTIzNA" will result "123" instead of "1234". I noticed that some service account tokens have this issue. This is why I added "}" in case it is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Unmarshalfunction used wrong parametersDecinstead of the new onenewDec.Second issue was that some tokens are being set with bad base64.
For example:
1234 in base64 is: "MTIzNA=="
If you will remove the "==" in some places you will still get "1234" but in the Go function it remove the "4".
So using "MTIzNA" will result "123" instead of "1234".
I noticed that some service account tokens have this issue. This is why I added "}" in case it is missing.
Pull Request (PR) Checklist
pkg/merlin.go(if applicable)Change Type
Description