Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple sources into separate package #357

Closed
5 tasks done
pashagolub opened this issue Feb 8, 2024 · 0 comments · Fixed by #358
Closed
5 tasks done

decouple sources into separate package #357

pashagolub opened this issue Feb 8, 2024 · 0 comments · Fixed by #358
Assignees
@pashagolub
Labels
epic Large body of work broken down into a number of smaller issues refactoring Something done as it should've been done from the start
Milestone
Decoupling

Comments

@pashagolub
Copy link
Collaborator

pashagolub commented Feb 8, 2024 •
edited
Loading

  • add sources package with types
  • add Postgres config reader
  • add YAML config reader
  • move patroni discoverer from main
  • refactor sources obtaining in main
@pashagolub pashagolub added epic Large body of work broken down into a number of smaller issues refactoring Something done as it should've been done from the start labels Feb 8, 2024
@pashagolub pashagolub added this to the Decoupling milestone Feb 8, 2024
@pashagolub pashagolub self-assigned this Feb 8, 2024
pashagolub added a commit that referenced this issue Feb 8, 2024
@pashagolub
[!] decouple sources package from main, closes #357
651d462
@pashagolub pashagolub linked a pull request Feb 8, 2024 that will close this issue
[!] decouple sources package from main, closes #357 #358
Merged
pashagolub added a commit that referenced this issue Feb 8, 2024
@pashagolub
[!] decouple sources package from main, closes #357 (#358)
b81983a 
We support only one database type and it's Postgres. But we can get
information about monitored database from different sources, e.g.
poolers, patroni clusters, etc.

[!] decouple `sources` package from main, closes #357
[*] rename `DbType` to `Source` and introduce `SourceKind` type
[*] rename `ConnectionOpts` to `SourceOpts`
[-] remove unused `jsonTextToXXX()`
[*] move encrypt functions to `config`
[*] move `--config` to `SourceOpts`
[*] remove `ConfigFileToMonitoredDatabases()` from `main`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pashagolub pashagolub

Labels
epic Large body of work broken down into a number of smaller issues refactoring Something done as it should've been done from the start
Projects
None yet
Milestone
Decoupling
Development

Successfully merging a pull request may close this issue.

[!] decouple sources package from main, closes #357 cybertec-postgresql/pgwatch
1 participant
@pashagolub