Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[!] restructure code tree, closes #518 #521

Merged
merged 5 commits into from
Aug 26, 2024
Merged

[!] restructure code tree, closes #518 #521

merged 5 commits into from
Aug 26, 2024

Conversation

pashagolub
Copy link
Collaborator

  • get rid of src folder
  • put go.mod to the root folder
  • put packages in internal
  • provide one public api package to allow import for rpc sinks
  • put main.go under cmd\pgwatch
  • move utils\convert to cmd\pgwatch

@pashagolub
[!] restructure code tree, closes #518
47b43c8 
- get rid of `src` folder
- put `go.mod` to the root folder
- put packages in `internal`
- provide one public `api` package to allow import for rpc sinks
- put `main.go` under `cmd\pgwatch`
- move `utils\convert` to `cmd\pgwatch`
@pashagolub pashagolub linked an issue Aug 26, 2024 that may be closed by this pull request
restructure code tree #518
Closed
@pashagolub pashagolub self-assigned this Aug 26, 2024
@pashagolub pashagolub added enhancement New feature or request refactoring Something done as it should've been done from the start labels Aug 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10559865127

Details

  • 8 of 58 (13.79%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 28.501%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/pgwatch/main.go 0 1 0.0%
internal/sinks/postgres.go 3 4 75.0%
internal/metrics/logparse.go 0 3 0.0%
internal/webui/embed.go 0 3 0.0%
internal/reaper/file.go 0 5 0.0%
internal/sinks/prometheus.go 0 5 0.0%
cmd/pgwatch/version.go 0 10 0.0%
internal/reaper/reaper.go 0 10 0.0%
internal/reaper/database.go 0 12 0.0%
Totals Coverage Status
Change from base Build 10557708034: -1.0%
Covered Lines: 1386
Relevant Lines: 4863
💛 - Coveralls

@pashagolub pashagolub merged commit 364061e into master Aug 26, 2024
7 checks passed
@pashagolub pashagolub deleted the 518-restructure-code-tree branch August 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pashagolub pashagolub

Labels
enhancement New feature or request refactoring Something done as it should've been done from the start
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restructure code tree
2 participants
@pashagolub @coveralls