feat: opt-in allowing cascade delete of namespaces #150
+298
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
allow-cascade-delete
branch
from
11091e3
to
ef5b826
Compare
|
@zoetrope PTAL! I think the CI is broken because the Helm install in the failing workflow is performed using the latest release of Accurate, and not included the changes in this PR. This seems wrong to me. Please advice! |
|
@erikgb diff --git a/.github/workflows/helm.yaml b/.github/workflows/helm.yaml
index ce3ea8e..7a9f5e1 100644
--- a/.github/workflows/helm.yaml
+++ b/.github/workflows/helm.yaml
@@ -43,12 +43,14 @@ jobs:
kubectl -n cert-manager wait --for=condition=available --timeout=180s --all deployments
- name: Prepare values.yaml
run: |
- LATEST=$(curl -s "https://api.github.com/repos/cybozu-go/accurate/releases/latest" | jq -r .tag_name)
- APP_VERSION=${LATEST#v}
+ docker build -t accurate:dev .
+ kind load docker-image accurate:dev --name=chart-testing
mkdir -p charts/accurate/ci/
cat > charts/accurate/ci/ci-values.yaml <<EOF
image:
- tag: $APP_VERSION
+ repository: accurate
+ tag: dev
+ pullPolicy: Never
EOF
- name: Run chart-testing (install)
run: ct install --config ct.yaml |
erikgb
force-pushed
the
allow-cascade-delete
branch
from
ef5b826
to
008f558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an opt-in to configure webhooks to allow the deletion of namespaces with children (a.k.a. cascading deletion) which will be blocked by default.
Close #119