implement reconcileDiscardJob #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first step to implement reconcileDiscardJob. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
This commit is the 2nd step for implementing reconcileDiscardJob Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
This commit is the 4th step for implementing reconcileDiscardJob. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
This commit should be the last step for implementing reconcileDiscardJob. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
support-discard-job
branch
from
077697c to
81bcf8c
Compare
satoru-takeuchi
requested changes
Nov 25, 2024
|
|
||
| result, err := mbr.reconcileDiscardJob(ctx, backup, &snapshotTarget{}) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(result.Requeue).To(BeFalse()) |
There was a problem hiding this comment.
Could you also verify discard PV, PVC, Jobs aren't really created? It's to distinguish the discard-was-completed case and the did-not-create-anything case.
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
support-discard-job
branch
from
81bcf8c to
cec8e55
Compare
|
I've amended and force-pushed my last commit. I'm waiting for the CI to pass. |
satoru-takeuchi
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.