Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency libs & newer mysql and k8s #676

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

takara9
Copy link
Contributor

@takara9 takara9 commented May 15, 2024

Notable change:
Due to an update of the github.com/aws/aws-sdk-go-v2 library, users must specify the region of the bucket in their BackupPolicy if the bucketConfig.backendType is s3 or not specified. If the region is not specified, the backup/restore job will crash.
ref: aws/aws-sdk-go-v2#2502

Dependencies:

  • Bump up controller-runtime 0.15.0
  • Bump golang version 1.22.3

Additional Support :

  • Support for MySQL version 8.0.36 and 8.0.37
  • Support for Kubernetes version 1.28,1.29

@takara9 takara9 marked this pull request as draft May 16, 2024 01:15
@takara9 takara9 self-assigned this May 16, 2024
@takara9 takara9 requested a review from masa213f May 17, 2024 00:58
@takara9 takara9 marked this pull request as ready for review May 17, 2024 01:00
go.mod Show resolved Hide resolved
.github/workflows/build-mysql-container.yaml Show resolved Hide resolved
.github/actions/dbtest/action.yaml Show resolved Hide resolved
kustomization.yaml Outdated Show resolved Hide resolved
@takara9 takara9 requested a review from masa213f May 23, 2024 02:35
pkg/bucket/s3.go Outdated Show resolved Hide resolved
pkg/bucket/s3_test.go Outdated Show resolved Hide resolved
@takara9 takara9 requested a review from masa213f May 31, 2024 05:03
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
@takara9 takara9 requested a review from masa213f June 3, 2024 02:48
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
@takara9 takara9 requested a review from masa213f June 6, 2024 01:00
@takara9 takara9 force-pushed the update-for-k8s-1.28-No10 branch 2 times, most recently from f0cda10 to e3b1a64 Compare June 6, 2024 05:14
masa213f
masa213f previously approved these changes Jun 6, 2024
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f self-requested a review June 6, 2024 07:13
@masa213f masa213f dismissed their stale review June 6, 2024 07:18

I'll rereview

@takara9 takara9 force-pushed the update-for-k8s-1.28-No10 branch 2 times, most recently from 35ce921 to 2c6569c Compare June 6, 2024 07:31
@takara9 takara9 changed the title Update dependency Update dependency libs & newer mysql and k8s Jun 6, 2024
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

run contorller-gen and add new crd files

update k8s version in build-mysql-container

update dependency tool in Makefiles

update Ubuntu 22.04 under .github/workflow

Add support ver in README

parent 496bfb6
author Maho Takara <takara@cybozu.co.jp> 1716173837 +0000
committer Maho Takara <takara@cybozu.co.jp> 1716184596 +0000

parent 496bfb6
author Maho Takara <takara@cybozu.co.jp> 1716173837 +0000
committer Maho Takara <takara@cybozu.co.jp> 1716184398 +0000

Down greade support ver k8s 1.27 - 1.29

run contorller-gen and add new crd files

update Ubuntu 22.04 under .github/workflow

fix conflict

fix conflict

fix unwnated marge

fix conflict

update for review comment

update go modules

update go api

update go api

fix miss version

fix lib miss version

update go mod

update go mod

change s3 module

Add AWS S3 region

update S3 param

update s3 test

update grpc api

update for formatter report

update CRD

go k8s api libs 0.29.5

update CRD

Remove config.WithRegion()

Add environment env AWS_REGION

Add AWS_REGION in test case

change for review commnet

change for gofmt error

Revice explanation of AWS S3

edit for review comment

fix error

fix error of lint

resolve conflict

check for pd

Delete unnecessary comment and space
@takara9 takara9 merged commit 6b776e8 into main Jun 7, 2024
21 checks passed
@takara9 takara9 deleted the update-for-k8s-1.28-No10 branch June 7, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants