Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release flow #14

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Add release flow #14

merged 3 commits into from
Nov 13, 2023

Conversation

zeroalphat
Copy link
Contributor

@zeroalphat zeroalphat commented Oct 26, 2023

@zeroalphat zeroalphat self-assigned this Oct 26, 2023
@zeroalphat zeroalphat force-pushed the add-release-flow branch 2 times, most recently from 25a8059 to 441a77e Compare November 8, 2023 07:01
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
umezawatakeshi
umezawatakeshi previously approved these changes Nov 9, 2023
.goreleaser.yaml Outdated
Comment on lines 50 to 51
owner: zeroalphat
name: necoperf-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used for test in your repository?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was left with the settings I used for testing.

docs/release.md Outdated
Comment on lines 29 to 30
git checkout main
git tag -a -m "Release v$VERSION" "v$VERSION"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to ensure the freshness of the local HEAD.

Suggested change
git checkout main
git tag -a -m "Release v$VERSION" "v$VERSION"
git checkout main
git pull
git tag -a -m "Release v$VERSION" "v$VERSION"

Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroalphat zeroalphat merged commit 36a2ca4 into main Nov 13, 2023
4 checks passed
@zeroalphat zeroalphat deleted the add-release-flow branch November 13, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants