🫥 remove use navigate (#589)

cyclops-ui · Sep 24, 2024 · 0a59a6e · 0a59a6e
1 parent dcbde24
commit 0a59a6e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 14 deletions.
diff --git a/cyclops-ui/src/components/pages/EditModule/EditModule.tsx b/cyclops-ui/src/components/pages/EditModule/EditModule.tsx
@@ -12,7 +12,6 @@ import {
   Typography,
 } from "antd";
 import axios from "axios";
-import { useNavigate } from "react-router";
 import { LockFilled, UnlockFilled } from "@ant-design/icons";
 
 import { useParams } from "react-router-dom";
@@ -101,8 +100,6 @@ const EditModule = () => {
   const [loadValues, setLoadValues] = useState(false);
   const [loadTemplate, setLoadTemplate] = useState(false);
 
-  const history = useNavigate();
-
   let { moduleName } = useParams();
 
   const mapsToArray = useCallback((fields: any[], values: any): any => {
@@ -410,7 +407,7 @@ const EditModule = () => {
           </Button>{" "}
           <Button
             htmlType="button"
-            onClick={() => history("/modules/" + moduleName)}
+            onClick={() => (window.location.href = "/modules/" + moduleName)}
             disabled={!loadTemplate}
           >
             Back

diff --git a/cyclops-ui/src/components/pages/History.tsx b/cyclops-ui/src/components/pages/History.tsx
@@ -1,6 +1,5 @@
 import React, { useEffect, useState } from "react";
 import { Button, Col, Modal, Row, Table, Typography } from "antd";
-import { useNavigate } from "react-router";
 import axios from "axios";
 import { useParams } from "react-router-dom";
 import ReactDiffViewer from "react-diff-viewer";
@@ -15,7 +14,6 @@ require(`ace-builds/src-noconflict/snippets/sass`);
 require(`ace-builds/src-noconflict/theme-github`);
 
 const ModuleHistory = () => {
-  const history = useNavigate();
   const [error, setError] = useState({
     message: "",
     description: "",
@@ -266,7 +264,7 @@ const ModuleHistory = () => {
       <Button
         style={{ float: "right" }}
         htmlType="button"
-        onClick={() => history("/modules/" + moduleName)}
+        onClick={() => (window.location.href = "/modules/" + moduleName)}
       >
         Back
       </Button>

diff --git a/cyclops-ui/src/components/pages/Modules/Modules.tsx b/cyclops-ui/src/components/pages/Modules/Modules.tsx
@@ -13,7 +13,6 @@ import {
   Popover,
   Checkbox,
 } from "antd";
-import { useNavigate } from "react-router";
 
 import axios from "axios";
 
@@ -26,7 +25,6 @@ import { mapResponseError } from "../../../utils/api/errors";
 const { Title } = Typography;
 
 const Modules = () => {
-  const history = useNavigate();
   const [allData, setAllData] = useState([]);
   const [filteredData, setFilteredData] = useState([]);
   const [loadingModules, setLoadingModules] = useState(false);
@@ -83,7 +81,7 @@ const Modules = () => {
   }, [moduleHealthFilter, allData, searchInputFilter]);
 
   const handleClick = () => {
-    history("/modules/new");
+    window.location.href = "/modules/new";
   };
   const handleSelectItem = (selectedItems: any[]) => {
     setModuleHealthFilter(selectedItems);

diff --git a/cyclops-ui/src/components/pages/NewModule/NewModule.tsx b/cyclops-ui/src/components/pages/NewModule/NewModule.tsx
@@ -15,7 +15,6 @@ import {
   notification,
 } from "antd";
 import axios from "axios";
-import { useNavigate } from "react-router";
 import { findMaps, flattenObjectKeys } from "../../../utils/form";
 import "./custom.css";
 import defaultTemplate from "../../../static/img/default-template-icon.png";
@@ -90,8 +89,6 @@ const NewModule = () => {
 
   const [namespaces, setNamespaces] = useState<string[]>([]);
 
-  const history = useNavigate();
-
   const [notificationApi, contextHolder] = notification.useNotification();
   const openNotification = (errors: FeedbackError[]) => {
     notificationApi.error({
@@ -702,7 +699,7 @@ const NewModule = () => {
               </Button>{" "}
               <Button
                 htmlType="button"
-                onClick={() => history("/")}
+                onClick={() => (window.location.href = "/")}
                 disabled={loadingTemplate || loadingTemplateInitialValues}
               >
                 Back