Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resource details for PersistentVolumeClaims #258

Closed
petar-cvit opened this issue May 5, 2024 · 3 comments · Fixed by #259
Closed

Implement resource details for PersistentVolumeClaims #258

petar-cvit opened this issue May 5, 2024 · 3 comments · Fixed by #259
Assignees
Labels
controller Update on controller go Pull requests that update Go code good first issue Good for newcomers

Comments

@petar-cvit
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When fetching resources for a Module, some resources are supported to return details about a specific resource. For example, the endpoint for Deployments will return more information about pods and their statuses, and the endpoint for Services will return information about the ports.

If you want to fetch information about a Deployment form default namespace called demo-app you would call:
/resources?group=apps&version=v1&kind=Deployment&name=demo-app&namespace=default

The goal of the issue is to support PersistentVolumeClaims on the same endpoint. The endpoint for fetching PVC data would look like this: /resources?group=&version=v1&kind=PersistentVolumeClaim&name=<name>&namespace=<namespace>.

The handler function for the endpoint is here, and you will have to handle a new type here.

In the response, you can add the size of the PVC, access mode, and anything else you would find useful.

@petar-cvit petar-cvit added good first issue Good for newcomers go Pull requests that update Go code controller Update on controller labels May 5, 2024
@Tanmay-21
Copy link
Contributor

Hi @petar-cvit can you please assign this to me. Would love to contribute!

@petar-cvit
Copy link
Collaborator Author

Hey @Tanmay-21, sure thing!

@Tanmay-21
Copy link
Contributor

Hey @petar-cvit, I have raised a PR for required code changes - #259
Pls Review and also guide me how can I test this with ease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller Update on controller go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants