-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl(backend): add pvc data fetch api functionality #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tanmay-21 thanks for the PR. Left one comment for the PVC struct
AccessModes: persistentvolumeclaim.spec.accessModes, | ||
Size: persistentvolumeclaim.spec.resources.requests.storage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix this as well? Also, do we need to checkout for nil pointer dereference if Storage is nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need deleted value populated here as false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think storage is a necessary field in PVCs so might never be nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not compile. You should .Spec.AccessModes with capital letters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think storage is a necessary field in PVCs so might never be nil
I was thinking the same thing, but would still like to be cautious since we are dealing with pointers. If its nil, you can default to 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @Tanmay-21! |
Implements #258
Closes #258
Description
This PR adds support for fetching PersistentVolumeClaims data on /resource endpoint in
cyclops-ctrl
.